Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: net/socket/websocket_transport_client_socket_pool.cc

Issue 1898133002: Add reprioritization to socket pools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/websocket_transport_client_socket_pool.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/websocket_transport_client_socket_pool.cc
diff --git a/net/socket/websocket_transport_client_socket_pool.cc b/net/socket/websocket_transport_client_socket_pool.cc
index 0239226da9910a94aea263729e8da7bbcad538f9..8d8fd4bc2846706b80b1dd9e760d151ebcdcd369 100644
--- a/net/socket/websocket_transport_client_socket_pool.cc
+++ b/net/socket/websocket_transport_client_socket_pool.cc
@@ -392,6 +392,19 @@ void WebSocketTransportClientSocketPool::RequestSockets(
NOTIMPLEMENTED();
}
+void WebSocketTransportClientSocketPool::SetPriority(
+ const std::string& group_name,
+ ClientSocketHandle* handle,
+ RequestPriority priority) {
+ // Since sockets requested by RequestSocket are bound early and
+ // stalled_request_{queue,map} don't take priorities into account, there's
+ // nothing to do within the pool to change priority or the request.
+ // TODO(rdsmith, ricea): Make stalled_request_{queue,map} take priorities
+ // into account.
+ // TODO(rdsmith): Investigate plumbing the reprioritization request to the
+ // connect job.
+}
+
void WebSocketTransportClientSocketPool::CancelRequest(
const std::string& group_name,
ClientSocketHandle* handle) {
« no previous file with comments | « net/socket/websocket_transport_client_socket_pool.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698