Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1972)

Unified Diff: net/http/http_network_transaction.cc

Issue 1898133002: Add reprioritization to socket pools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix glitch in ClientSocketHandle API contract. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_proxy_client_socket_pool.h » ('j') | net/http/http_stream_factory_impl_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.cc
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index b7ceb430bd9ea8bc3f1b202cdf7aaf483f3b4976..66bd911ca96c5dc112b131a24b31d4adfd63cfec 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -421,11 +421,12 @@ void HttpNetworkTransaction::PopulateNetErrorDetails(
void HttpNetworkTransaction::SetPriority(RequestPriority priority) {
priority_ = priority;
- // TODO: Note that if throttling is ever implemented below this
- // level, either of the two below calls may result in request
- // completion, callbacks, and the potential deletion of this object
- // (like the call below to throttle_->SetPriority()). In that case,
- // this code will need to be modified.
+ // TODO(rdsmith): Note also that if priority-based throttling is
+ // ever implemented below this level, either of the two below calls
+ // may result in request completion, callbacks, and the potential
+ // deletion of this object (like the call below to
+ // throttle_->SetPriority()). In that case, this code will need to
+ // be modified.
mmenke 2017/01/05 20:18:35 Ok, now I understand what you mean because of your
Randy Smith (Not in Mondays) 2017/01/13 23:05:44 Done, though I felt a need to be a bit wordier onc
if (stream_request_)
stream_request_->SetPriority(priority);
if (stream_)
« no previous file with comments | « no previous file | net/http/http_proxy_client_socket_pool.h » ('j') | net/http/http_stream_factory_impl_job.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698