Add reprioritization to socket pools.

net/http/http_network_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <memory>
 #include <set>
 #include <utility>
 #include <vector>
@@ skipping 403 matching lines @@
 void HttpNetworkTransaction::PopulateNetErrorDetails(
     NetErrorDetails* details) const {
   *details = net_error_details_;
   if (stream_)
     stream_->PopulateNetErrorDetails(details);
 }
 
 void HttpNetworkTransaction::SetPriority(RequestPriority priority) {
   priority_ = priority;
 
-  // TODO: Note that if throttling is ever implemented below this
-  // level, either of the two below calls may result in request
-  // completion, callbacks, and the potential deletion of this object
-  // (like the call below to throttle_->SetPriority()).  In that case,
-  // this code will need to be modified.
+  // TODO(rdsmith): Note that if any code indirectly executed by
+  // |stream_request_->SetPriority()| or |stream_->SetPriority()|
+  // ever implements a throttling mechanism where changing a request's
+  // priority may cause a this or another request to synchronously succeed
+  // or fail, that callback could synchronously delete |*this|, causing
+  // a crash on return to this code.
+  //
+  // |throttle_->SetPriority()| has exactly the above attributes, which
+  // is why it's the last call in this function.
+
   if (stream_request_)
     stream_request_->SetPriority(priority);
   if (stream_)
     stream_->SetPriority(priority);
 
   if (throttle_)
     throttle_->SetPriority(priority);
   // The above call may have resulted in deleting |*this|.
 }
 
@@ skipping 1261 matching lines @@
   DCHECK(stream_request_);
 
   // Since the transaction can restart with auth credentials, it may create a
   // stream more than once. Accumulate all of the connection attempts across
   // those streams by appending them to the vector:
   for (const auto& attempt : stream_request_->connection_attempts())
     connection_attempts_.push_back(attempt);
 }
 
 }  // namespace net