Add reprioritization to socket pools.

net/http/http_stream_factory_impl_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl_job.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 300 matching lines @@
     if (connection_ && connection_->socket()) {
       connection_->socket()->Disconnect();
     }
     delegate_->OnOrphanedJobComplete(this);
   }
   // |this| may be deleted after this call.
 }
 
 void HttpStreamFactoryImpl::Job::SetPriority(RequestPriority priority) {
   priority_ = priority;
-  // TODO(akalin): Propagate this to |connection_| and maybe the
-  // preconnect state.
+  // connection_ is moved to be owned by the newly created stream

[mmenke, 2017/01/03 22:51:22]

"connection_ is moved to be owned by the newly created stream..." -> Maybe
"Ownership of |connection_| is passed to the newly created stream or H2 session
in DoCreateStream(), and the consumer not notified immediately, so this call may
occur when connection_ is null."

[mmenke, 2017/01/03 22:51:22]

Also, would it make more sense to put the TODO about fixing that case here?  I
think all you need to do (Excluding tests) to fix that is:

if (stream_)
  stream_->SetPriority(priority);

[Randy Smith (Not in Mondays), 2017/01/05 03:47:18]

Huh; I had thought the PostTask() went to an object method above this one, but
it's actually just to OnStreamReadyCallback().  Yes, I think that would work
fine, and I think it's a better API contract (i.e. that the consumer should
always be able to affect the priority via one of stream_request_ or stream_).  

Do you see any way to test it?  There aren't currently any
HttpStreamFactoryImpl::Job unit tests, which I think I could make work; without
that (specifically without notification of connection establishment separate
from stream ready) I don't know how to get into the state where the PostTask is
in flight.

Failing seeing how to test it (relatively easily--this CL is a distraction from
my main tasks ATM) I've moved the TODO.

[Randy Smith (Not in Mondays), 2017/01/05 03:47:18]

Done.

+  // (or equivalent) in DoCreateStream(), and the consumer not notified
+  // until after a PostTask, so this call may occur when connection_ is null.
+  if (connection_)
+    connection_->SetPriority(priority);
+  // TODO(akalin): Maybe Propagate this to the preconnect state.
 }
 
 bool HttpStreamFactoryImpl::Job::was_alpn_negotiated() const {
   return was_alpn_negotiated_;
 }
 
 NextProto HttpStreamFactoryImpl::Job::negotiated_protocol() const {
   return negotiated_protocol_;
 }
 
@@ skipping 1172 matching lines @@
 
   ConnectionAttempts socket_attempts = connection_->connection_attempts();
   if (connection_->socket()) {
     connection_->socket()->GetConnectionAttempts(&socket_attempts);
   }
 
   delegate_->AddConnectionAttemptsToRequest(this, socket_attempts);
 }
 
 }  // namespace net