Use Zone to correctly measure async operations.

Use Zone to correctly measure async operations.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/33253905e7e97b943f278d7d08f29979dc94a11b

[ahe, 2016-04-20 15:44:58]

Description was changed from

==========
Use Zone to correctly measure async operations.

Based on the following Dartino patches:

  https://codereview.chromium.org//1454373002
  https://codereview.chromium.org/1482983002
==========

to

==========
Use Zone to correctly measure async operations.
==========

[ahe, 2016-04-20 15:45:50]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2016-04-20 15:45:51]

Note, this is based on the following Dartino patches:

  https://codereview.chromium.org//1454373002
  https://codereview.chromium.org/1482983002

I'm trying to land this in master.

[Johnni Winther, 2016-04-25 09:23:02]

lgtm

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/apiimp...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:237: StringBuffer timings = new
StringBuffer();
Can we avoid the computation of [timings] when we're not verbose?

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common/tasks.dart (right):

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common/tasks.dart:79: measurer.stopAsyncWallClock();
'of [previous]' -> 'of whether [previous]'

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:399: measurer.startWallClock();
Why do call [startWallClock] here? Isn't is already started?

What about the time used in the subclass (apiimpl) before its super-call?

[ahe, 2016-04-26 11:35:00]

Thank you, Johnni!

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/apiimp...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:237: StringBuffer timings = new
StringBuffer();
On 2016/04/25 09:23:02, Johnni Winther wrote:
> Can we avoid the computation of [timings] when we're not verbose?

Done.

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common/tasks.dart (right):

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common/tasks.dart:79: measurer.stopAsyncWallClock();
On 2016/04/25 09:23:02, Johnni Winther wrote:
> 'of [previous]' -> 'of whether [previous]'

Done.

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1898043004/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:399: measurer.startWallClock();
On 2016/04/25 09:23:02, Johnni Winther wrote:
> Why do call [startWallClock] here? Isn't is already started?

For normal dart2js runs from the command line, it is started already. However,
when calling run multiple times, it isn't.

> What about the time used in the subclass (apiimpl) before its super-call?

This isn't ideal, but I'm not sure what would be a better alternative.

[ahe, 2016-04-26 12:27:46]

Description was changed from

==========
Use Zone to correctly measure async operations.
==========

to

==========
Use Zone to correctly measure async operations.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/33253905e7e97b943f278d7d08f29979dc94a11b
==========

[ahe, 2016-04-26 12:27:48]

Committed patchset #3 (id:40001) manually as
33253905e7e97b943f278d7d08f29979dc94a11b (presubmit successful).