Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 189803007: Revert 255151 "Make chrome_elf use thunks instead of function po..." (Closed)

Created:
6 years, 9 months ago by Cait (Slow)
Modified:
6 years, 9 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255151 "Make chrome_elf use thunks instead of function po..." (Crashy on today's canary) > Make chrome_elf use thunks instead of function pointers. > > 1. Add functionality to ServiceResolverThunk to copy a thunk without patching. > 2. Move chrome_elf thunk-handling code to a common location. > 3. Use a thunk instead of a f'n ptr for redirects. > > BUG=334379 > > Review URL: https://codereview.chromium.org/183833004 TBR=caitkp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -288 lines) Patch
M trunk/src/chrome_elf/blacklist/blacklist.cc View 4 chunks +128 lines, -8 lines 0 comments Download
M trunk/src/chrome_elf/chrome_elf.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/chrome_elf/create_file/chrome_create_file_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome_elf/ntdll_cache.h View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome_elf/ntdll_cache.cc View 2 chunks +2 lines, -52 lines 0 comments Download
D trunk/src/chrome_elf/thunk_getter.h View 1 chunk +0 lines, -16 lines 0 comments Download
D trunk/src/chrome_elf/thunk_getter.cc View 1 chunk +0 lines, -142 lines 0 comments Download
M trunk/src/sandbox/win/src/service_resolver.h View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/src/sandbox/win/src/service_resolver_32.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M trunk/src/sandbox/win/src/service_resolver_64.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Cait (Slow)
6 years, 9 months ago (2014-03-07 22:06:19 UTC) #1
Cait (Slow)
6 years, 9 months ago (2014-03-07 22:06:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255703 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698