Issue 189803002: [GCM] Observe the event listener adding such that GCM can be started

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189803002: [GCM] Observe the event listener adding such that GCM can be started (Closed)

Created:
6 years, 9 months ago by jianli

Modified:
6 years, 9 months ago

Reviewers:
fgorski

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[GCM] Observe the event listener adding such that GCM can be started BUG=349578 TEST=Manual test by following repro steps R=fgorski@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255729

Patch Set 3 : Fix trybots #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -9 lines)			Patch
M	chrome/browser/extensions/api/gcm/gcm_api.h	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/gcm/gcm_api.cc	View	1 2	3 chunks	+22 lines, -3 lines	0 comments	Download
M	chrome/browser/services/gcm/gcm_profile_service.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/services/gcm/gcm_profile_service.cc	View		3 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/services/gcm/gcm_profile_service_unittest.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fgorski

lgtm, but consider adding a test for the event triggering the start https://codereview.chromium.org/189803002/diff/1/chrome/browser/extensions/api/gcm/gcm_api.cc File chrome/browser/extensions/api/gcm/gcm_api.cc ...

6 years, 9 months ago (2014-03-07 17:56:07 UTC) #2

jianli

6 years, 9 months ago (2014-03-08 01:16:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r255729 (presubmit successful).

Expand Messages | Collapse Messages

Issue 189803002: [GCM] Observe the event listener adding such that GCM can be started (Closed)

Description

Patch Set 1 #

Patch Set 2 : Patch to land #

Patch Set 3 : Fix trybots #

Messages