Remove IPDF_TextPage, IPDF_TextPageFind and IPDF_LinkExtract interfaces.

Remove IPDF_TextPage, IPDF_TextPageFind and IPDF_LinkExtract interfaces.

Each was only used by one subclass. Removed and used the concrete classes.

BUG=pdfium:468
Committed: https://pdfium.googlesource.com/pdfium/+/a28ae388f3859c52630deb6ef3d0ea468e5177e3

[dsinclair, 2016-04-18 20:55:01]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-18 20:55:02]

PTAL.

[Lei Zhang, 2016-04-18 20:58:38]

You have red trybots.

[dsinclair, 2016-04-18 21:01:55]

On 2016/04/18 20:58:38, Lei Zhang wrote:
> You have red trybots.

Weird, Linux is happy. Uploaded a potential fix, will see what the bots do.

[Lei Zhang, 2016-04-18 21:08:11]

Ya, but IWYU...

Do you want to try uploading with some manually set --similarity= value, so that
core/fpdftext/include/cpdf_linkextract.h shows up as a move from
core/fpdftext/fpdf_text_int.h?

https://codereview.chromium.org/1897993002/diff/1/fpdfsdk/fpdftext.cpp
File fpdfsdk/fpdftext.cpp (right):

https://codereview.chromium.org/1897993002/diff/1/fpdfsdk/fpdftext.cpp#newcode42
fpdfsdk/fpdftext.cpp:42: delete static_cast<CPDF_TextPage*>(text_page);
Do you think UnderlyingFromFPDFTextPage(), similar to
UnderlyingFromFPDFDocument(), would be nicer than static_casts everywhere?

[Tom Sepez, 2016-04-18 22:50:13]

https://codereview.chromium.org/1897993002/diff/20001/core/fpdftext/fpdf_text...
File core/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/1897993002/diff/20001/core/fpdftext/fpdf_text...
core/fpdftext/fpdf_text_int.cpp:107: const uint16_t* const
g_UnicodeData_Normalization_Maps[5] = {
nit: data should probably go ahead of the functions.

[dsinclair, 2016-04-18 23:12:04]

On 2016/04/18 21:08:11, Lei Zhang wrote:
> Ya, but IWYU...
>

I try to, sometimes I miss things when shuffling code around.


> Do you want to try uploading with some manually set --similarity= value, so
that
> core/fpdftext/include/cpdf_linkextract.h shows up as a move from
> core/fpdftext/fpdf_text_int.h?
>

I could try, three of the files are from fpdf_text_int.h so I'm not sure how
well it would work.
 
> https://codereview.chromium.org/1897993002/diff/1/fpdfsdk/fpdftext.cpp
> File fpdfsdk/fpdftext.cpp (right):
> 
>
https://codereview.chromium.org/1897993002/diff/1/fpdfsdk/fpdftext.cpp#newcode42
> fpdfsdk/fpdftext.cpp:42: delete static_cast<CPDF_TextPage*>(text_page);
> Do you think UnderlyingFromFPDFTextPage(), similar to
> UnderlyingFromFPDFDocument(), would be nicer than static_casts everywhere?

[dsinclair, 2016-04-19 12:49:30]

Description was changed from

==========
Remove IPDF_TextPage, IPDF_TextPageFind and IPDF_LinkExtract interfaces.

Each was only used by one subclass. Removed and used the concrete classes.
==========

to

==========
Remove IPDF_TextPage, IPDF_TextPageFind and IPDF_LinkExtract interfaces.

Each was only used by one subclass. Removed and used the concrete classes.

BUG=pdfium:468
==========

[dsinclair, 2016-04-19 13:06:32]

Patchset #3 (id:40001) has been deleted

[dsinclair, 2016-04-19 13:07:03]

Patchset #3 (id:60001) has been deleted

[dsinclair, 2016-04-19 13:08:07]

PTAL.

If I change the --similarity much lower it matches the wrong files and doesn't
make any sense.

https://codereview.chromium.org/1897993002/diff/1/fpdfsdk/fpdftext.cpp
File fpdfsdk/fpdftext.cpp (right):

https://codereview.chromium.org/1897993002/diff/1/fpdfsdk/fpdftext.cpp#newcode42
fpdfsdk/fpdftext.cpp:42: delete static_cast<CPDF_TextPage*>(text_page);
On 2016/04/18 21:08:11, Lei Zhang wrote:
> Do you think UnderlyingFromFPDFTextPage(), similar to
> UnderlyingFromFPDFDocument(), would be nicer than static_casts everywhere?

Done.

https://codereview.chromium.org/1897993002/diff/20001/core/fpdftext/fpdf_text...
File core/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/1897993002/diff/20001/core/fpdftext/fpdf_text...
core/fpdftext/fpdf_text_int.cpp:107: const uint16_t* const
g_UnicodeData_Normalization_Maps[5] = {
On 2016/04/18 22:50:13, Tom Sepez wrote:
> nit: data should probably go ahead of the functions.

Done.

[Lei Zhang, 2016-04-19 17:35:40]

lgtm

[dsinclair, 2016-04-19 17:39:04]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-19 17:39:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897993002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897993002/80001

[commit-bot: I haz the power, 2016-04-19 17:39:26]

Description was changed from

==========
Remove IPDF_TextPage, IPDF_TextPageFind and IPDF_LinkExtract interfaces.

Each was only used by one subclass. Removed and used the concrete classes.

BUG=pdfium:468
==========

to

==========
Remove IPDF_TextPage, IPDF_TextPageFind and IPDF_LinkExtract interfaces.

Each was only used by one subclass. Removed and used the concrete classes.

BUG=pdfium:468

Committed:
https://pdfium.googlesource.com/pdfium/+/a28ae388f3859c52630deb6ef3d0ea468e51...
==========

[commit-bot: I haz the power, 2016-04-19 17:39:27]

Committed patchset #3 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/a28ae388f3859c52630deb6ef3d0ea468e51...