VM: Avoid smi-check when loading class-ids from known non-smi values

VM: Avoid smi-check when loading class-ids from known non-smi values.

The code for LoadClassId is a lot smaller when we know that the value can't be a smi.

BUG=
R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/66fa89750798e9444cb2fc38dc068766167a9eab

[Florian Schneider, 2016-04-18 20:54:13]

Description was changed from

==========
VM: Avoid smi-check when loading class-ids from known non-smi values

BUG=
==========

to

==========
VM: Avoid smi-check when loading class-ids from known non-smi values.

The code for LoadClassId is a lot smaller when we know that the value can't be a
smi.

BUG=
==========

[Florian Schneider, 2016-04-18 20:54:24]

fschneider@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2016-04-18 21:00:09]

lgtm

https://codereview.chromium.org/1897983002/diff/1/runtime/vm/flow_graph_type_...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/1897983002/diff/1/runtime/vm/flow_graph_type_...
runtime/vm/flow_graph_type_propagator.cc:470: return
FromAbstractType(Type::ZoneHandle(Type::SmiType()), kNonNullable);
Could use Create(kSmiCid, Type::ZoneHandle(Type::SmiType())) like ::Bool()

[Florian Schneider, 2016-04-19 10:34:39]

https://codereview.chromium.org/1897983002/diff/1/runtime/vm/flow_graph_type_...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/1897983002/diff/1/runtime/vm/flow_graph_type_...
runtime/vm/flow_graph_type_propagator.cc:470: return
FromAbstractType(Type::ZoneHandle(Type::SmiType()), kNonNullable);
On 2016/04/18 21:00:09, Vyacheslav Egorov (Google) wrote:
> Could use Create(kSmiCid, Type::ZoneHandle(Type::SmiType())) like ::Bool()

Done.

[Florian Schneider, 2016-04-19 10:45:44]

Description was changed from

==========
VM: Avoid smi-check when loading class-ids from known non-smi values.

The code for LoadClassId is a lot smaller when we know that the value can't be a
smi.

BUG=
==========

to

==========
VM: Avoid smi-check when loading class-ids from known non-smi values.

The code for LoadClassId is a lot smaller when we know that the value can't be a
smi.

BUG=
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/66fa89750798e9444cb2fc38dc068766167a9eab
==========

[Florian Schneider, 2016-04-19 10:45:45]

Committed patchset #2 (id:20001) manually as
66fa89750798e9444cb2fc38dc068766167a9eab (presubmit successful).