Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1897973006: Remove `SKIP` expectations for Mac tests related to scroll animations. (Closed)

Created:
4 years, 8 months ago by bokan
Modified:
4 years, 8 months ago
Reviewers:
weiliangc
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove `SKIP` expectations for Mac tests related to scroll animations. These layout tests were skipped on Mac since it used to be impossible to enable scroll animations on a per-test basis in Mac. This was fixed in r376025 so these tests should be able to run now. BUG=364614 Committed: https://crrev.com/1d0f31fb32a23ffee0957b9af8e382e24e83923e Cr-Commit-Position: refs/heads/master@{#388619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bokan
+weiliangc@ since you filed bug 364614. There's still issues with these tests as they're marked ...
4 years, 8 months ago (2016-04-20 15:11:01 UTC) #2
weiliangc
Thanks for the fix! LGTM
4 years, 8 months ago (2016-04-20 15:34:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897973006/1
4 years, 8 months ago (2016-04-20 19:54:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:15:44 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d0f31fb32a23ffee0957b9af8e382e24e83923e
Cr-Commit-Position: refs/heads/master@{#388619}

Powered by Google App Engine
This is Rietveld 408576698