Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1897953004: Report passive prevent defaulted event listeners correctly to the console. (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report passive prevent defaulted event listeners correctly to the console. Previously only document level listeners would be reported to the console that were preventDefaulted. Load the LocalDOMWindow from the event path instead. BUG=604743 Committed: https://crrev.com/c55f4ccbd722aa7eaa4e94309661e10d128ae098 Cr-Commit-Position: refs/heads/master@{#388240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/events/Event.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
dtapuska
4 years, 8 months ago (2016-04-19 15:21:01 UTC) #3
bokan
lgtm
4 years, 8 months ago (2016-04-19 15:45:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897953004/1
4 years, 8 months ago (2016-04-19 17:47:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 17:52:49 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:13:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c55f4ccbd722aa7eaa4e94309661e10d128ae098
Cr-Commit-Position: refs/heads/master@{#388240}

Powered by Google App Engine
This is Rietveld 408576698