Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: media/audio/virtual_audio_input_stream.h

Issue 1897953003: Unmute Tab Audio For Desktop Share (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/virtual_audio_input_stream.h
diff --git a/media/audio/virtual_audio_input_stream.h b/media/audio/virtual_audio_input_stream.h
index 28d8804ef3901ceafa52659557cbc3d683e21d53..d69942b5834b0d22af620b1413036b0a42becdb1 100644
--- a/media/audio/virtual_audio_input_stream.h
+++ b/media/audio/virtual_audio_input_stream.h
@@ -64,11 +64,11 @@ class MEDIA_EXPORT VirtualAudioInputStream : public AudioInputStream {
// VirtualAudioInputStream must outlive all attached streams, so any attached
// stream must be closed (which causes a detach) before
// VirtualAudioInputStream is destroyed.
- virtual void AddOutputStream(VirtualAudioOutputStream* stream,
+ virtual void AddOutputStream(AudioConverter::InputCallback* stream,
miu 2016/04/21 00:15:25 s/stream/input/
miu 2016/04/21 00:15:25 Please adjust the naming of these methods. Sugges
qiangchen 2016/04/28 00:00:56 Done.
qiangchen 2016/04/28 00:00:56 Done.
const AudioParameters& output_params);
miu 2016/04/21 00:15:25 s/output_params/params/
qiangchen 2016/04/28 00:00:56 Done.
// Detaches a VirtualAudioOutputStream and removes it as input.
- virtual void RemoveOutputStream(VirtualAudioOutputStream* stream,
+ virtual void RemoveOutputStream(AudioConverter::InputCallback* stream,
const AudioParameters& output_params);
private:

Powered by Google App Engine
This is Rietveld 408576698