Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1897933002: Add new Linux signing keys to packages. (Closed)

Created:
4 years, 8 months ago by Michael Moss
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, sburford
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
M chrome/installer/linux/common/apt.include View 1 chunk +67 lines, -0 lines 0 comments Download
M chrome/installer/linux/common/rpm.include View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Michael Moss
4 years, 8 months ago (2016-04-18 18:25:54 UTC) #1
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-18 19:14:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897933002/1
4 years, 8 months ago (2016-04-18 21:56:05 UTC) #4
Michael Moss
FYI, to test, I did a local "official" build and installed the the resulting deb ...
4 years, 8 months ago (2016-04-18 21:56:55 UTC) #5
chromium-reviews
Hi, https://codereview.chromium.org/1897933002/diff/1/chrome/installer/linux/common/rpm.include?context=10&column_width=80&tab_spaces=8 Lines 13-15 will prevent the new key from installing if you already have ...
4 years, 8 months ago (2016-04-18 23:22:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/52499)
4 years, 8 months ago (2016-04-19 00:01:02 UTC) #8
Michael Moss
On 2016/04/18 23:22:11, chromium-reviews wrote: > Hi, > > https://codereview.chromium.org/1897933002/diff/1/chrome/installer/linux/common/rpm.include?context=10&column_width=80&tab_spaces=8 > Lines 13-15 will prevent ...
4 years, 8 months ago (2016-04-19 03:27:11 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d7368111613da050a22597f70c1314453a093174 Cr-Commit-Position: refs/heads/master@{#388124}
4 years, 8 months ago (2016-04-19 03:31:23 UTC) #11
Michael Moss
4 years, 8 months ago (2016-04-19 03:32:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7368111613da050a22597f70c1314453a093174 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698