Record how frequently EEP provides valid estimates

Record how frequently EEP provides valid estimates

Record a metric every time External Estimate Provider (EEP)
provides a valid RTT or a valid bandwidth sample.

BUG=604417
Committed: https://crrev.com/1a0aa535a97f6c807c3b969cd319ab0d23762018
Cr-Commit-Position: refs/heads/master@{#389943}

[tbansal1, 2016-04-18 17:59:45]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-04-18 18:00:59]

Description was changed from

==========
BUG=
==========

to

==========
Record how frequently EEP provides valid estimates

Record a metric every time External Estimate Provider (EEP)
provides a valid RTT or a valid bandwidth sample.

BUG=604417
==========

[tbansal1, 2016-04-18 18:01:21]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2016-04-18 18:01:21]

bengr: PTAL at *. Thanks.

[bengr, 2016-04-21 22:58:37]

lgtm with a nit. It would be interesting also to know how close those estimates
are to what Chrome converges on.

https://codereview.chromium.org/1897903002/diff/20001/net/base/network_qualit...
File net/base/network_quality_estimator_unittest.cc (right):

https://codereview.chromium.org/1897903002/diff/20001/net/base/network_qualit...
net/base/network_quality_estimator_unittest.cc:860: 1
/*EXTERNAL_ESTIMATE_PROVIDER_STATUS_AVAILABLE*/, 1);
nit: Add spaces: /* EXTERNAL...AVAILABLE */, here and below

[tbansal1, 2016-04-26 21:24:55]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2016-04-26 21:25:07]

On 2016/04/21 22:58:37, bengr wrote:
> lgtm with a nit. It would be interesting also to know how close those
estimates
> are to what Chrome converges on.
Done.
> 
>
https://codereview.chromium.org/1897903002/diff/20001/net/base/network_qualit...
> File net/base/network_quality_estimator_unittest.cc (right):
> 
>
https://codereview.chromium.org/1897903002/diff/20001/net/base/network_qualit...
> net/base/network_quality_estimator_unittest.cc:860: 1
> /*EXTERNAL_ESTIMATE_PROVIDER_STATUS_AVAILABLE*/, 1);
> nit: Add spaces: /* EXTERNAL...AVAILABLE */, here and below

[tbansal1, 2016-04-26 21:25:28]

tbansal@chromium.org changed reviewers:
+ asvitkine@chromium.org

[tbansal1, 2016-04-26 21:25:28]

asvitkine: PTAL at histograms.xml.

https://codereview.chromium.org/1897903002/diff/20001/net/base/network_qualit...
File net/base/network_quality_estimator_unittest.cc (right):

https://codereview.chromium.org/1897903002/diff/20001/net/base/network_qualit...
net/base/network_quality_estimator_unittest.cc:860: 1
/*EXTERNAL_ESTIMATE_PROVIDER_STATUS_AVAILABLE*/, 1);
On 2016/04/21 22:58:37, bengr wrote:
> nit: Add spaces: /* EXTERNAL...AVAILABLE */, here and below

Done.

[Alexei Svitkine (slow), 2016-04-26 21:27:05]

lgtm

https://codereview.chromium.org/1897903002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1897903002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:33139: +    Recorded every time the
external estimate provider  provides a valid RTT
Nit: Remove extra space.

[tbansal1, 2016-04-26 21:29:25]

https://codereview.chromium.org/1897903002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1897903002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:33139: +    Recorded every time the
external estimate provider  provides a valid RTT
On 2016/04/26 21:27:05, Alexei Svitkine wrote:
> Nit: Remove extra space.

Done.

[tbansal1, 2016-04-26 21:29:25]

https://codereview.chromium.org/1897903002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1897903002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:33139: +    Recorded every time the
external estimate provider  provides a valid RTT
On 2016/04/26 21:27:05, Alexei Svitkine wrote:
> Nit: Remove extra space.

Done.

[tbansal1, 2016-04-26 23:36:50]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-04-26 23:36:51]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1897903002/#ps80001
(title: "Removed whitespace (asvitkine's comment)")

[commit-bot: I haz the power, 2016-04-26 23:37:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897903002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897903002/80001

[commit-bot: I haz the power, 2016-04-26 23:42:16]

Description was changed from

==========
Record how frequently EEP provides valid estimates

Record a metric every time External Estimate Provider (EEP)
provides a valid RTT or a valid bandwidth sample.

BUG=604417
==========

to

==========
Record how frequently EEP provides valid estimates

Record a metric every time External Estimate Provider (EEP)
provides a valid RTT or a valid bandwidth sample.

BUG=604417
==========

[commit-bot: I haz the power, 2016-04-26 23:42:17]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-04-26 23:43:17]

Description was changed from

==========
Record how frequently EEP provides valid estimates

Record a metric every time External Estimate Provider (EEP)
provides a valid RTT or a valid bandwidth sample.

BUG=604417
==========

to

==========
Record how frequently EEP provides valid estimates

Record a metric every time External Estimate Provider (EEP)
provides a valid RTT or a valid bandwidth sample.

BUG=604417

Committed: https://crrev.com/1a0aa535a97f6c807c3b969cd319ab0d23762018
Cr-Commit-Position: refs/heads/master@{#389943}
==========

[commit-bot: I haz the power, 2016-04-26 23:43:17]

Patchset 3 (id:??) landed as
https://crrev.com/1a0aa535a97f6c807c3b969cd319ab0d23762018
Cr-Commit-Position: refs/heads/master@{#389943}