build/common.gypi - Issue 1897863006: Replace WTF::Optional the base::Optional implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1897863006: Replace WTF::Optional the base::Optional implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wtfoptional: notonclang Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 74836e7ab5931378d7b5a7d0853e031a1ba6e1aa..d3c029a94eeb77afa5d4a4ed6823984ac86b6828 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3918,6 +3918,12 @@

['_toolset=="target"', {

'conditions': [

['clang==0', {

+ 'cflags': [

+ # Don't warn about "maybe" uninitialized. Clang doesn't

+ # include this in -Wall but gcc does, and it gives false

+ # positives.

+ '-Wno-maybe-uninitialized',

+ ],

'cflags_cc': [

# The codesourcery arm-2009q3 toolchain warns at that the ABI

# has changed whenever it encounters a varargs function. This

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »