Add dictionary for HTTP fuzzers.

Add dictionary for HTTP fuzzers.

Currently used for HttpStreamParser and HttpProxyClientSocket fuzzers,
so mostly includes strings those two fuzzers are interested in.

BUG=598037, 599582
Committed: https://crrev.com/e15732fd7e646ad24924e8506adf388206caf3a5
Cr-Commit-Position: refs/heads/master@{#387969}

[mmenke, 2016-04-18 16:35:46]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2016-04-18 16:35:47]

https://codereview.chromium.org/1897863002/diff/1/net/data/http/http.dict
File net/data/http/http.dict (right):

https://codereview.chromium.org/1897863002/diff/1/net/data/http/http.dict#new...
net/data/http/http.dict:51: "HTTP/1.1 302 Found\x0ALocation:
http://lost/\x0A\x0A"
https://bugs.chromium.org/p/chromium/issues/detail?id=603964#c7 had some
discussions on the choice of shorter strings, more integration-y strings, or
both.

[mmenke, 2016-04-18 16:36:49]

On 2016/04/18 16:35:47, mmenke wrote:
> https://codereview.chromium.org/1897863002/diff/1/net/data/http/http.dict
> File net/data/http/http.dict (right):
> 
>
https://codereview.chromium.org/1897863002/diff/1/net/data/http/http.dict#new...
> net/data/http/http.dict:51: "HTTP/1.1 302 Found\x0ALocation:
> http://lost/%5Cx0A%5Cx0A%22
> https://bugs.chromium.org/p/chromium/issues/detail?id=603964#c7 had some
> discussions on the choice of shorter strings, more integration-y strings, or
> both.

Oh, and the "bug" I was running into was that the "dict" option requires one
dash, not two.

[eroman, 2016-04-18 17:26:24]

lgtm

https://codereview.chromium.org/1897863002/diff/1/net/data/http/http.dict
File net/data/http/http.dict (right):

https://codereview.chromium.org/1897863002/diff/1/net/data/http/http.dict#new...
net/data/http/http.dict:16: "\x09"
Does the format support regular C escape sequences like \t  and \r etc? Those
would be more readable IMO.

Another combined sequence that is interesting is 

CR LF TAB

For header line continuations.

Redundant though since can be produces from the smaller substrings already
given.

[mmenke, 2016-04-18 17:36:03]

https://codereview.chromium.org/1897863002/diff/1/net/data/http/http.dict
File net/data/http/http.dict (right):

https://codereview.chromium.org/1897863002/diff/1/net/data/http/http.dict#new...
net/data/http/http.dict:16: "\x09"
On 2016/04/18 17:26:24, eroman wrote:
> Does the format support regular C escape sequences like \t  and \r etc? Those
> would be more readable IMO.

Unfortunately, it does not, except for \" and \\

> Another combined sequence that is interesting is 
> 
> CR LF TAB
> 
> For header line continuations.
> 
> Redundant though since can be produces from the smaller substrings already
> given.

Added.  They're funky enough that I think it's worth adding.

[mmenke, 2016-04-18 17:36:08]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-04-18 17:36:09]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1897863002/#ps20001
(title: "Add continuation")

[commit-bot: I haz the power, 2016-04-18 17:36:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897863002/20001

[commit-bot: I haz the power, 2016-04-18 18:48:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-18 18:53:21]

Description was changed from

==========
Add dictionary for HTTP fuzzers.

Currently used for HttpStreamParser and HttpProxyClientSocket fuzzers,
so mostly includes strings those two fuzzers are interested in.

BUG=598037,599582
==========

to

==========
Add dictionary for HTTP fuzzers.

Currently used for HttpStreamParser and HttpProxyClientSocket fuzzers,
so mostly includes strings those two fuzzers are interested in.

BUG=598037,599582

Committed: https://crrev.com/e15732fd7e646ad24924e8506adf388206caf3a5
Cr-Commit-Position: refs/heads/master@{#387969}
==========

[commit-bot: I haz the power, 2016-04-18 18:53:22]

Patchset 2 (id:??) landed as
https://crrev.com/e15732fd7e646ad24924e8506adf388206caf3a5
Cr-Commit-Position: refs/heads/master@{#387969}