Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1897823005: X87: Change calling convention of CallApiGetterStub to accept the AccessorInfo. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Change calling convention of CallApiGetterStub to accept the AccessorInfo. port d2b0a4b727f77f97960c7fa71da3431591dc959f (r35606) original commit message: MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>; BUG= Committed: https://crrev.com/5b822b31fe59f98c940519de584f2b60fdfb2a46 Cr-Commit-Position: refs/heads/master@{#35611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -71 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +39 lines, -16 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-19 09:52:55 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-19 09:55:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897823005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897823005/1
4 years, 8 months ago (2016-04-19 09:56:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 10:19:22 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 10:21:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b822b31fe59f98c940519de584f2b60fdfb2a46
Cr-Commit-Position: refs/heads/master@{#35611}

Powered by Google App Engine
This is Rietveld 408576698