Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1897803003: [Media Router WebUI] Switch back to sink view after blocking issue is resolved. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Switch back to sink view after blocking issue is resolved. When a blocking issue is resolved, container's |issue| is set to null. Currently, the UI doesn't switch back to the sink list view, leaving the user in a relatively blank issue view with no way of switching back. Note that blocking issues take precedence to non-blocking issues, so there is no case where a blocking issue can be replaced by a non-blocking issue. It always becomes null when it is resolved. This change also fixes an issue where the issue banner's offsetHeight is always 0. BUG=601502 Review URL: https://codereview.chromium.org/1868983003 Cr-Commit-Position: refs/heads/master@{#387451} (cherry picked from commit fee1baea9fdb05cb5867f46eb1ffe5c850be9d9c) Committed: https://chromium.googlesource.com/chromium/src/+/f8eb1fe71cc1cd9506175970a2b933f32f374449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -12 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +19 lines, -8 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js View 4 chunks +60 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
apacible
4 years, 8 months ago (2016-04-18 21:21:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8eb1fe71cc1cd9506175970a2b933f32f374449.

Powered by Google App Engine
This is Rietveld 408576698