Check scrollbars before hit testing border radius

Check scrollbars before hit testing border radius

This patch fixes a regression from [1] where scrollbar hit testing
would be ignored if a border radius was present. By excluding hit tests
on the scrollbars (included in overflowClipRect(...)), we now properly
give scrollbars precedence over border radius.

[1] https://crrev.com/b6749c9b582f70fc9a5dcb364087e30cf45a7306

BUG=597946
Committed: https://crrev.com/dab89b99996bb173c6f3747e70191687089eaa8c
Cr-Commit-Position: refs/heads/master@{#387999}

[pdr., 2016-04-18 04:14:32]

Description was changed from

==========
Check scrollbar hit test before hit testing border radius

This patch fixes a regression from [1] where scrollbar hit testing
would be ignored if a border radius was present. By excluding hit tests
on the scrollbars (included in overflowClipRect(...)), we now properly
give scrollbars precedence over border radius.

[1] https://crrev.com/b6749c9b582f70fc9a5dcb364087e30cf45a7306

BUG=597946
==========

to

==========
Check scrollbars before hit testing border radius

This patch fixes a regression from [1] where scrollbar hit testing
would be ignored if a border radius was present. By excluding hit tests
on the scrollbars (included in overflowClipRect(...)), we now properly
give scrollbars precedence over border radius.

[1] https://crrev.com/b6749c9b582f70fc9a5dcb364087e30cf45a7306

BUG=597946
==========

[pdr., 2016-04-18 04:14:32]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[pdr., 2016-04-18 04:14:40]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 04:14:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897753002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897753002/1

[commit-bot: I haz the power, 2016-04-18 05:36:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 05:36:55]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-04-18 16:17:39]

https://codereview.chromium.org/1897753002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/hittesting/inner-border-radius-hittest.html
(right):

https://codereview.chromium.org/1897753002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/hittesting/inner-border-radius-hittest.html:14:
// At top-left corner, insider inner border radius.
s/insider/inside/ throughout.

https://codereview.chromium.org/1897753002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/hittesting/inner-border-radius-hittest.html:47:
shouldBe("document.elementFromPoint(x + 240, y + 150).id",
"'roundedBoxWithScrollbars'");
I'm struggling a bit to understand the logic change here. Can you walk me
through an example?

https://codereview.chromium.org/1897753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right):

https://codereview.chromium.org/1897753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:1632: if
(!locationInContainer.intersects(overflowClipRect(accumulatedOffset,
IncludeOverlayScrollbarSize)))
When would overflowClipRect(...) be smaller than
style()->getRoundedInnerBorderFor(...) below? Related to my other comment.

[chrishtr, 2016-04-18 18:55:29]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-04-18 18:55:30]

lgtm

LGTM, but please follow up as discussed offline renaming the enum.

[commit-bot: I haz the power, 2016-04-18 18:56:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897753002/20001

[commit-bot: I haz the power, 2016-04-18 20:19:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-18 20:21:17]

Description was changed from

==========
Check scrollbars before hit testing border radius

This patch fixes a regression from [1] where scrollbar hit testing
would be ignored if a border radius was present. By excluding hit tests
on the scrollbars (included in overflowClipRect(...)), we now properly
give scrollbars precedence over border radius.

[1] https://crrev.com/b6749c9b582f70fc9a5dcb364087e30cf45a7306

BUG=597946
==========

to

==========
Check scrollbars before hit testing border radius

This patch fixes a regression from [1] where scrollbar hit testing
would be ignored if a border radius was present. By excluding hit tests
on the scrollbars (included in overflowClipRect(...)), we now properly
give scrollbars precedence over border radius.

[1] https://crrev.com/b6749c9b582f70fc9a5dcb364087e30cf45a7306

BUG=597946

Committed: https://crrev.com/dab89b99996bb173c6f3747e70191687089eaa8c
Cr-Commit-Position: refs/heads/master@{#387999}
==========

[commit-bot: I haz the power, 2016-04-18 20:21:19]

Patchset 2 (id:??) landed as
https://crrev.com/dab89b99996bb173c6f3747e70191687089eaa8c
Cr-Commit-Position: refs/heads/master@{#387999}