Source/core/editing/ApplyBlockElementCommand.cpp - Issue 189773005: Revert of Have Position deal with more references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ApplyBlockElementCommand.cpp

Issue 189773005: Revert of Have Position deal with more references (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ApplyBlockElementCommand.cpp

diff --git a/Source/core/editing/ApplyBlockElementCommand.cpp b/Source/core/editing/ApplyBlockElementCommand.cpp

index b622fc93b5072942a287b9e8ed0cde9fd279173d..8de6c1669cedc8dc0f0af50c099a9a33472240cd 100644

--- a/Source/core/editing/ApplyBlockElementCommand.cpp

+++ b/Source/core/editing/ApplyBlockElementCommand.cpp

@@ -111,7 +111,7 @@

insertNodeAt(blockquote, start);

RefPtr<Element> placeholder = createBreakElement(document());

appendNode(placeholder, blockquote);

- setEndingSelection(VisibleSelection(positionBeforeNode(*placeholder), DOWNSTREAM, endingSelection().isDirectional()));

+ setEndingSelection(VisibleSelection(positionBeforeNode(placeholder.get()), DOWNSTREAM, endingSelection().isDirectional()));

return;

}

« no previous file with comments | « Source/core/dom/PositionIterator.cpp ('k') | Source/core/editing/ApplyStyleCommand.cpp » ('j') | no next file with comments »