Source/core/editing/CompositeEditCommand.cpp - Issue 189773005: Revert of Have Position deal with more references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.cpp

Issue 189773005: Revert of Have Position deal with more references (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/CompositeEditCommand.cpp

diff --git a/Source/core/editing/CompositeEditCommand.cpp b/Source/core/editing/CompositeEditCommand.cpp

index 2a6fb149113d60442dd010591007674710c39d2a..2e0897bea7891c4d74d7ee185db8b4329beabccf 100644

--- a/Source/core/editing/CompositeEditCommand.cpp

+++ b/Source/core/editing/CompositeEditCommand.cpp

@@ -1342,7 +1342,7 @@

// We want to replace this quoted paragraph with an unquoted one, so insert a br

// to hold the caret before the highest blockquote.

insertNodeBefore(br, highestBlockquote);

- VisiblePosition atBR(positionBeforeNode(*br));

+ VisiblePosition atBR(positionBeforeNode(br.get()));

// If the br we inserted collapsed, for example foo<br><blockquote>...</blockquote>, insert

// a second one.

if (!isStartOfParagraph(atBR))