Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1897713002: Make analyzer more strong mode compliant (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -21 lines) Patch
M pkg/analyzer/lib/src/dart/ast/ast.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 6 chunks +136 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-04-16 17:14:21 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-16 17:18:18 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-04-16 19:28:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf1fa31c90a76f244be283b40256cdc0bc29825b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698