Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1897673002: Revert of Get rid of UnsafeCurrent in Sampler (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Get rid of UnsafeCurrent in Sampler (patchset #12 id:220001 of https://codereview.chromium.org/1858143003/ ) Reason for revert: [Sheriff] Breaks tsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/8999 Original issue's description: > Get rid of UnsafeCurrent in Sampler > > Currently we are using UnsafeCurrent in async signal handler to acquire the > isolate of VM thread, but we want to get rid of that since it prevents V8 from > being thread agnostic. > > This patch replaces UnsafeCurrent with a static map, where we store a map of > samplers for threads, and makes it accessible by signal handler. > > BUG=v8:4889 > LOG=n > > Committed: https://crrev.com/62fb4775fea0d56d8a175baf1d902213f6752168 > Cr-Commit-Position: refs/heads/master@{#35541} TBR=jochen@chromium.org,alph@chromium.org,fmeawad@chromium.org,yangguo@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4889 Committed: https://crrev.com/ba011836e4aea1116b6bf21907ece3704fd6cca0 Cr-Commit-Position: refs/heads/master@{#35545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -186 lines) Patch
M src/isolate.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/profiler/sampler.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/profiler/sampler.cc View 15 chunks +16 lines, -178 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Get rid of UnsafeCurrent in Sampler
4 years, 8 months ago (2016-04-16 06:30:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897673002/1
4 years, 8 months ago (2016-04-16 06:30:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 06:30:59 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 06:33:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba011836e4aea1116b6bf21907ece3704fd6cca0
Cr-Commit-Position: refs/heads/master@{#35545}

Powered by Google App Engine
This is Rietveld 408576698