Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 189763002: Remove chrome.pak and its references. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, jamesr, tony
Visibility:
Public.

Description

Remove chrome.pak and its references. chromite was updated to no longer install chrome.pak in https://gerrit.chromium.org/gerrit/66855 (Aug 2013) and that version was into chrome already so it should be good to delete it now. BUG=52609 TEST=None R=thakis@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255567

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert chrome_repack_resources.gypi changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
D chrome/chrome_repack_chrome.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
tfarina
6 years, 9 months ago (2014-03-07 01:34:37 UTC) #1
tfarina
https://codereview.chromium.org/189763002/diff/1/chrome/chrome_resources.gyp File chrome/chrome_resources.gyp (left): https://codereview.chromium.org/189763002/diff/1/chrome/chrome_resources.gyp#oldcode332 chrome/chrome_resources.gyp:332: 'includes': ['chrome_repack_resources.gypi'] ops, I shouldn't have removed this line. ...
6 years, 9 months ago (2014-03-07 01:35:59 UTC) #2
Nico
Thanks! https://codereview.chromium.org/189763002/diff/1/chrome/chrome_resources.gyp File chrome/chrome_resources.gyp (left): https://codereview.chromium.org/189763002/diff/1/chrome/chrome_resources.gyp#oldcode332 chrome/chrome_resources.gyp:332: 'includes': ['chrome_repack_resources.gypi'] On 2014/03/07 01:36:00, tfarina wrote: > ...
6 years, 9 months ago (2014-03-07 01:38:10 UTC) #3
Nico
patch set 2 lgtm, thanks!
6 years, 9 months ago (2014-03-07 01:38:27 UTC) #4
tfarina
OK, now it is ready.
6 years, 9 months ago (2014-03-07 01:38:36 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-07 03:39:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/189763002/20001
6 years, 9 months ago (2014-03-07 03:42:26 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 04:00:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 04:00:35 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-07 04:19:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/189763002/20001
6 years, 9 months ago (2014-03-07 04:24:49 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 06:04:31 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 06:04:31 UTC) #13
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-07 06:23:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/189763002/20001
6 years, 9 months ago (2014-03-07 06:26:48 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 09:24:47 UTC) #16
Message was sent while issue was closed.
Change committed as 255567

Powered by Google App Engine
This is Rietveld 408576698