Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1897583002: Revert of aw: Ensure WebView stays alive until functor detach (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of aw: Ensure WebView stays alive until functor detach (patchset #1 id:1 of https://codereview.chromium.org/1880243004/ ) Reason for revert: API changed Original issue's description: > aw: Ensure WebView stays alive until functor detach > > Android will not guarantee that the WebView is not garbage colllected > before functor detached is called. So we need to add a gc root while the > functor detached callback is pending. > > BUG=597167 > > Committed: https://crrev.com/8e2e091e5c565b90e76ceb85dd4c848013c5cf94 > Cr-Commit-Position: refs/heads/master@{#387071} TBR=tobiasjs@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=597167 Committed: https://crrev.com/3400c0da62249a66b9e6f5f0f6ef27dd89c50926 Cr-Commit-Position: refs/heads/master@{#387773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 4 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
boliu
Created Revert of aw: Ensure WebView stays alive until functor detach
4 years, 8 months ago (2016-04-15 23:56:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897583002/1
4 years, 8 months ago (2016-04-15 23:57:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897583002/1
4 years, 8 months ago (2016-04-16 00:02:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897583002/1
4 years, 8 months ago (2016-04-16 00:32:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 00:58:33 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 00:59:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3400c0da62249a66b9e6f5f0f6ef27dd89c50926
Cr-Commit-Position: refs/heads/master@{#387773}

Powered by Google App Engine
This is Rietveld 408576698