Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: media/blink/websourcebuffer_impl.cc

Issue 1897533002: Clean up WebSourceBufferClient interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediasource/SourceBuffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/websourcebuffer_impl.cc
diff --git a/media/blink/websourcebuffer_impl.cc b/media/blink/websourcebuffer_impl.cc
index 9386f5222eca6a9145c7f5e53e6853ebebfa37ca..feb8c5b5adcf07a74d479f32ffb68d73e89a7d3f 100644
--- a/media/blink/websourcebuffer_impl.cc
+++ b/media/blink/websourcebuffer_impl.cc
@@ -179,15 +179,16 @@ void WebSourceBufferImpl::InitSegmentReceived(scoped_ptr<MediaTracks> tracks) {
std::vector<blink::WebSourceBufferClient::MediaTrackInfo> trackInfoVector;
for (const auto& track : tracks->tracks()) {
- trackInfoVector.push_back(
- std::make_tuple(mediaTrackTypeToBlink(track->type()),
- blink::WebString::fromUTF8(track->id()),
- blink::WebString::fromUTF8(track->kind()),
- blink::WebString::fromUTF8(track->label()),
- blink::WebString::fromUTF8(track->language())));
+ blink::WebSourceBufferClient::MediaTrackInfo trackInfo;
+ trackInfo.trackType = mediaTrackTypeToBlink(track->type());
+ trackInfo.byteStreamTrackId = blink::WebString::fromUTF8(track->id());
+ trackInfo.kind = blink::WebString::fromUTF8(track->kind());
+ trackInfo.label = blink::WebString::fromUTF8(track->label());
+ trackInfo.language = blink::WebString::fromUTF8(track->language());
+ trackInfoVector.push_back(trackInfo);
}
- std::vector<blink::WebMediaPlayer::TrackId> blinkTrackIds =
+ blink::WebVector<blink::WebMediaPlayer::TrackId> blinkTrackIds =
esprehn 2016/04/15 20:56:00 Whats the purpose of this if we just ignore the va
servolk 2016/04/15 21:02:32 This information is necessary to be able to map bl
haraken 2016/04/16 01:06:02 I'd suggest you add the |blinkTrackIds| in the nex
client_->initializationSegmentReceived(trackInfoVector);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediasource/SourceBuffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698