Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 189753002: Bluetooth: use generic names for fake devices (Closed)

Created:
6 years, 9 months ago by keybuk
Modified:
6 years, 9 months ago
Reviewers:
stevenjb, armansito
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@modalias-device-id
Visibility:
Public.

Description

Bluetooth: use generic names for fake devices Originally these names had been named based on similarly behaving devices we had in our inventory, change the names of both the variables and displayed names to be more generic and instead describe their behavior. BUG=346367 TEST=device_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -246 lines) Patch
M chromeos/dbus/fake_bluetooth_device_client.h View 2 chunks +32 lines, -32 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_device_client.cc View 16 chunks +110 lines, -110 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_input_client.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 44 chunks +98 lines, -100 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
keybuk
stevenjb: since he complained ;-)
6 years, 9 months ago (2014-03-07 01:29:40 UTC) #1
stevenjb
lgtm
6 years, 9 months ago (2014-03-07 01:35:01 UTC) #2
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 9 months ago (2014-03-07 01:36:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/189753002/1
6 years, 9 months ago (2014-03-07 01:48:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 04:23:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg, mac_chromium_rel
6 years, 9 months ago (2014-03-07 04:23:52 UTC) #6
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 9 months ago (2014-03-07 06:51:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/189753002/1
6 years, 9 months ago (2014-03-07 06:53:44 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 15:28:18 UTC) #9
Message was sent while issue was closed.
Change committed as 255620

Powered by Google App Engine
This is Rietveld 408576698