Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1897513002: Fill out the implementation of synthetic getters/setters in the summary linker. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fill out the implementation of synthetic getters/setters in the summary linker. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7670f2a6df0575ecbd5222047e0c19e5f70d17c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -28 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 6 chunks +73 lines, -16 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-15 19:17:29 UTC) #2
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-15 19:49:51 UTC) #3
scheglov
LGTM
4 years, 8 months ago (2016-04-15 19:51:21 UTC) #4
Paul Berry
4 years, 8 months ago (2016-04-15 20:32:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7670f2a6df0575ecbd5222047e0c19e5f70d17c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698