Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: base/metrics/field_trial.h

Issue 1897493002: Even more instrumentation to diagnose an Android render crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add more comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/metrics/field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial.h
diff --git a/base/metrics/field_trial.h b/base/metrics/field_trial.h
index ef3538595773937d0971b7eef07da2d61fd9815a..a937683beaa47dddb9f363d88f48e17a324cccc8 100644
--- a/base/metrics/field_trial.h
+++ b/base/metrics/field_trial.h
@@ -347,6 +347,14 @@ class BASE_EXPORT FieldTrialList {
// Destructor Release()'s references to all registered FieldTrial instances.
~FieldTrialList();
+ // TODO(asvitkine): Temporary function to diagnose http://crbug.com/359406.
+ // Remove when that bug is fixed. This enables using a global map that checks
+ // the state of field trials between possible FieldTrialList instances. If
+ // enabled, a CHECK will be hit if it's seen that a field trial is given a
+ // different state then what was specified to a renderer process launch
+ // command line.
+ static void EnableGlobalStateChecks();
+
// Get a FieldTrial instance from the factory.
//
// |name| is used to register the instance with the FieldTrialList class,
« no previous file with comments | « no previous file | base/metrics/field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698