Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1897483003: Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (Closed)

Created:
4 years, 8 months ago by Will Harris
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3 id:60001 of https://codereview.chromium.org/1877503003/ ) Reason for revert: broke u2f see crbug.com/603962 Original issue's description: > Replace libusb in the Linux/Chrome OS USB I/O path. > > As a first step in adding support for connecting to USB devices on > Android this patch replaces the libusb-based implementation of > UsbDeviceHandle used on Linux and Chrome OS with one written directly to > the Linux usbdevfs ioctl interface. > > BUG=422562, 601627 > > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533 > Cr-Commit-Position: refs/heads/master@{#387315} TBR=juncai@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=422562, 601627, 603962 Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3 Cr-Commit-Position: refs/heads/master@{#387704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1088 lines) Patch
M device/usb/BUILD.gn View 2 chunks +0 lines, -15 lines 0 comments Download
M device/usb/usb.gyp View 2 chunks +0 lines, -14 lines 0 comments Download
M device/usb/usb_device_handle.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/usb_device_handle_unittest.cc View 1 chunk +6 lines, -36 lines 0 comments Download
D device/usb/usb_device_handle_usbfs.h View 1 chunk +0 lines, -151 lines 0 comments Download
D device/usb/usb_device_handle_usbfs.cc View 1 chunk +0 lines, -800 lines 0 comments Download
M device/usb/usb_device_impl.h View 4 chunks +2 lines, -10 lines 0 comments Download
M device/usb/usb_device_impl.cc View 7 chunks +25 lines, -62 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Will Harris
Created Revert of Replace libusb in the Linux/Chrome OS USB I/O path.
4 years, 8 months ago (2016-04-15 19:49:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897483003/1
4 years, 8 months ago (2016-04-15 19:49:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897483003/1
4 years, 8 months ago (2016-04-15 20:01:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897483003/1
4 years, 8 months ago (2016-04-15 20:31:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897483003/1
4 years, 8 months ago (2016-04-15 21:01:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897483003/1
4 years, 8 months ago (2016-04-15 21:31:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 21:37:39 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3 Cr-Commit-Position: refs/heads/master@{#387704}
4 years, 8 months ago (2016-04-15 21:39:18 UTC) #11
Reilly Grant (use Gerrit)
4 years, 8 months ago (2016-04-20 00:26:53 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1902313002/ by reillyg@chromium.org.

The reason for reverting is: Fixed Windows/OS X issue..

Powered by Google App Engine
This is Rietveld 408576698