Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1897483002: TaskScheduler: Add static_assert in TaskTraits::operator==. (Closed)

Created:
4 years, 8 months ago by fdoray
Modified:
4 years, 8 months ago
Reviewers:
robliao
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@6_threadpool
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler: Add static_assert in TaskTraits::operator==. Add a static_assert in TaskTraits::operator== to ensure that no member can be added to TaskTraits without updating operator==. BUG=553459 Committed: https://crrev.com/7e0a1ba8e64f9dc10769ad5709750a2c8b88c84c Cr-Commit-Position: refs/heads/master@{#387954}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add static_assert message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/task_scheduler/task_traits.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897483002/1
4 years, 8 months ago (2016-04-15 18:56:47 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 20:00:06 UTC) #4
fdoray
Can you review this CL? Thanks.
4 years, 8 months ago (2016-04-15 21:07:14 UTC) #6
robliao
https://codereview.chromium.org/1897483002/diff/1/base/task_scheduler/task_traits.cc File base/task_scheduler/task_traits.cc (right): https://codereview.chromium.org/1897483002/diff/1/base/task_scheduler/task_traits.cc#newcode43 base/task_scheduler/task_traits.cc:43: ""); We should have a message here. Maybe "TaskTraits ...
4 years, 8 months ago (2016-04-15 21:36:13 UTC) #7
fdoray
robliao@: Done. Can you take another look? https://codereview.chromium.org/1897483002/diff/1/base/task_scheduler/task_traits.cc File base/task_scheduler/task_traits.cc (right): https://codereview.chromium.org/1897483002/diff/1/base/task_scheduler/task_traits.cc#newcode43 base/task_scheduler/task_traits.cc:43: ""); On ...
4 years, 8 months ago (2016-04-18 13:07:58 UTC) #8
gab
Leaving this one to Rob :-)
4 years, 8 months ago (2016-04-18 15:52:17 UTC) #10
robliao
lgtm
4 years, 8 months ago (2016-04-18 16:58:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897483002/20001
4 years, 8 months ago (2016-04-18 17:00:28 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 18:12:23 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:13:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e0a1ba8e64f9dc10769ad5709750a2c8b88c84c
Cr-Commit-Position: refs/heads/master@{#387954}

Powered by Google App Engine
This is Rietveld 408576698