Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 1897463002: [DevTools] Add sorting to all tabs in network (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index 5c4f0e4d2a59117168f4bd8f2b15996a5da6330c..816b6c27c5d130742400d0e888a400fb0c71ea63 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -708,18 +708,60 @@ WebInspector.NetworkDataGridNode.InitialPriorityComparator = function(a, b)
/**
* @param {string} propertyName
- * @param {boolean} revert
* @param {!WebInspector.NetworkDataGridNode} a
* @param {!WebInspector.NetworkDataGridNode} b
* @return {number}
*/
-WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyName, revert, a, b)
+WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyName, a, b)
{
var aValue = a._request[propertyName];
var bValue = b._request[propertyName];
- if (aValue > bValue)
- return revert ? -1 : 1;
- if (bValue > aValue)
- return revert ? 1 : -1;
- return a._request.indentityCompare(b._request);
+ if (aValue == bValue)
+ return a._request.indentityCompare(b._request);
+ return aValue > bValue ? 1 : -1;
+}
+
+/**
+ * @param {string} propertyName
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
+WebInspector.NetworkDataGridNode.ResponseHeaderStringComparator = function(propertyName, a, b)
+{
+ var aValue = String(a._request.responseHeaderValue(propertyName) || "");
+ var bValue = String(b._request.responseHeaderValue(propertyName) || "");
+ return aValue.localeCompare(bValue) || a._request.indentityCompare(b._request);
+}
+
+/**
+ * @param {string} propertyName
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
+WebInspector.NetworkDataGridNode.ResponseHeaderNumberComparator = function(propertyName, a, b)
+{
+ var aValue = (a._request.responseHeaderValue(propertyName) !== undefined) ? parseFloat(a._request.responseHeaderValue(propertyName)) : -Infinity;
+ var bValue = (b._request.responseHeaderValue(propertyName) !== undefined) ? parseFloat(b._request.responseHeaderValue(propertyName)) : -Infinity;
+ if (aValue == bValue)
+ return a._request.indentityCompare(b._request);
+ return aValue > bValue ? 1 : -1;
+}
+
+/**
+ * @param {string} propertyName
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
+WebInspector.NetworkDataGridNode.ResponseHeaderDateComparator = function(propertyName, a, b)
+{
+ var aHeader = a._request.responseHeaderValue(propertyName);
+ var bHeader = b._request.responseHeaderValue(propertyName);
+ var aValue = aHeader ? new Date(aHeader).getTime() : -Infinity;
+ var bValue = bHeader ? new Date(bHeader).getTime() : -Infinity;
+ if (aValue == bValue)
+ return a._request.indentityCompare(b._request);
+ return aValue > bValue ? 1 : -1;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698