[DevTools] Add sorting to all tabs in network

third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index 5c4f0e4d2a59117168f4bd8f2b15996a5da6330c..888838e17800062fc2d06fb768fe3859b5d9982d 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -717,9 +717,55 @@ WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa
 {
     var aValue = a._request[propertyName];
     var bValue = b._request[propertyName];
-    if (aValue > bValue)
-        return revert ? -1 : 1;
-    if (bValue > aValue)
-        return revert ? 1 : -1;
-    return a._request.indentityCompare(b._request);
+    if (aValue == bValue)
+        return a._request.indentityCompare(b._request);
+    return ((aValue > bValue) ? 1 : -1) * (revert ? -1 : 1);
+}
+
+/**
+ * @param {string} propertyName
+ * @param {boolean} revert
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
+WebInspector.NetworkDataGridNode.ResponseHeaderStringComparator = function(propertyName, revert, a, b)
+{
+    var aValue = String(a._request.responseHeaderValue(propertyName) || "");
+    var bValue = String(b._request.responseHeaderValue(propertyName) || "");
+    return (aValue.localeCompare(bValue) * (revert ? -1 : 1)) || a._request.indentityCompare(b._request);

[caseq, 2016/04/15 21:30:00]

let's nuke revert, it's not used by callers and only adds complexity here.

[allada, 2016/04/15 22:57:11]

Done.

+}
+
+/**
+ * @param {string} propertyName
+ * @param {boolean} revert
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
+WebInspector.NetworkDataGridNode.ResponseHeaderNumberComparator = function(propertyName, revert, a, b)

[caseq, 2016/04/15 21:30:00]

ditto

[allada, 2016/04/15 22:57:11]

Done.

+{
+    var aValue = (a._request.responseHeaderValue(propertyName) !== undefined) ? parseFloat(a._request.responseHeaderValue(propertyName)) : -Infinity;
+    var bValue = (b._request.responseHeaderValue(propertyName) !== undefined) ? parseFloat(b._request.responseHeaderValue(propertyName)) : -Infinity;
+    if (aValue == bValue)
+        return a._request.indentityCompare(b._request);
+    return ((aValue > bValue) ? 1 : -1) * (revert ? -1 : 1);
+}
+
+/**
+ * @param {string} propertyName
+ * @param {boolean} revert
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
+WebInspector.NetworkDataGridNode.ResponseHeaderDateComparator = function(propertyName, revert, a, b)

[caseq, 2016/04/15 21:30:00]

ditto.

[allada, 2016/04/15 22:57:11]

Done.

+{
+    var aHeader = a._request.responseHeaderValue(propertyName);
+    var bHeader = b._request.responseHeaderValue(propertyName);
+    var aValue = aHeader ? new Date(aHeader).getTime() : -Infinity;
+    var bValue = bHeader ? new Date(bHeader).getTime() : -Infinity;
+    if (aValue == bValue)
+        return a._request.indentityCompare(b._request);
+    return ((aValue > bValue) ? 1 : -1) * (revert ? -1 : 1);
 }