Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1897453002: exernalize imagefactory guard (Closed)

Created:
4 years, 8 months ago by reed1
Modified:
4 years, 8 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

exernalize imagefactory guard BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1897453002 TBR= CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/2a04104ba0c40ea31f6bcf403bd69fda05935e5b

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M cmake/example.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImage.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897453002/1
4 years, 8 months ago (2016-04-15 17:11:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot/builds/888)
4 years, 8 months ago (2016-04-15 17:14:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897453002/20001
4 years, 8 months ago (2016-04-15 17:35:36 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 17:56:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2a04104ba0c40ea31f6bcf403bd69fda05935e5b

Powered by Google App Engine
This is Rietveld 408576698