Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1897443002: Load inline text boxes for focused element. (Closed)

Created:
4 years, 8 months ago by dmazzoni
Modified:
4 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Load inline text boxes for focused element. This allows TalkBack to navigate by word and line when a text box has focus, even if accessibility focus is elsewhere (like the virtual keyboard). BUG=603953 Committed: https://crrev.com/5bb13e6c74c867320875d2413b1e0666835e00c4 Cr-Commit-Position: refs/heads/master@{#394936}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Only editable text #

Patch Set 3 : Force re-serialization when focus changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/accessibility/renderer_accessibility.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
dmazzoni
4 years, 8 months ago (2016-04-15 16:55:50 UTC) #2
dmazzoni
Friendly ping
4 years, 8 months ago (2016-04-18 21:32:41 UTC) #3
David Tseng
https://codereview.chromium.org/1897443002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc File content/renderer/accessibility/blink_ax_tree_source.cc (right): https://codereview.chromium.org/1897443002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc#newcode204 content/renderer/accessibility/blink_ax_tree_source.cc:204: ancestor == GetMainDocument().focusedAccessibilityObject()) { Could this possibly give you ...
4 years, 8 months ago (2016-04-18 23:38:13 UTC) #4
dmazzoni
On 2016/04/18 23:38:13, David Tseng wrote: > https://codereview.chromium.org/1897443002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc > File content/renderer/accessibility/blink_ax_tree_source.cc (right): > > https://codereview.chromium.org/1897443002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc#newcode204 ...
4 years, 8 months ago (2016-04-19 18:24:24 UTC) #5
dmazzoni
Ready for another look.
4 years, 8 months ago (2016-04-21 18:30:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897443002/40001
4 years, 7 months ago (2016-05-19 19:39:13 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-19 19:39:15 UTC) #10
dmazzoni
Take another look?
4 years, 7 months ago (2016-05-19 21:32:38 UTC) #11
David Tseng
lgtm
4 years, 7 months ago (2016-05-19 22:02:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897443002/40001
4 years, 7 months ago (2016-05-19 22:09:17 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-20 00:45:48 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 00:48:20 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5bb13e6c74c867320875d2413b1e0666835e00c4
Cr-Commit-Position: refs/heads/master@{#394936}

Powered by Google App Engine
This is Rietveld 408576698