Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: components/omnibox/browser/url_prefix_unittest.cc

Issue 1897403002: Optimize URLPrefix::BestURLPrefix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes after review, round 2 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/browser/url_prefix.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/url_prefix_unittest.cc
diff --git a/components/omnibox/browser/url_prefix_unittest.cc b/components/omnibox/browser/url_prefix_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..25d00598328658d28b275a724a04c2831a6edf7a
--- /dev/null
+++ b/components/omnibox/browser/url_prefix_unittest.cc
@@ -0,0 +1,56 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/omnibox/browser/url_prefix.h"
+
+#include "base/strings/utf_string_conversions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+struct TestCase {
+ TestCase(const char* text,
+ const char* prefix_suffix,
+ const char* expected_prefix)
+ : text(base::ASCIIToUTF16(text)),
+ prefix_suffix(base::ASCIIToUTF16(prefix_suffix)),
+ expected_prefix(base::ASCIIToUTF16(expected_prefix)) {}
+ base::string16 text;
+ base::string16 prefix_suffix;
+ base::string16 expected_prefix;
+};
+} // namespace
+
+TEST(URLPrefix, BestURLPrefix) {
+ const TestCase test_cases[] = {
+ // Lowercase test cases with empty prefix suffix.
+ TestCase("https://www.yandex.ru", "", "https://www."),
+ TestCase("http://www.yandex.ru", "", "http://www."),
+ TestCase("ftp://www.yandex.ru", "", "ftp://www."),
+ TestCase("https://yandex.ru", "", "https://"),
+ TestCase("http://yandex.ru", "", "http://"),
+ TestCase("ftp://yandex.ru", "", "ftp://"),
+
+ // Mixed case test cases with empty prefix suffix.
+ TestCase("HTTPS://www.yandex.ru", "", "https://www."),
+ TestCase("http://WWW.yandex.ru", "", "http://www."),
+
+ // Cases with non empty prefix suffix.
+ TestCase("http://www.yandex.ru", "yan", "http://www."),
+ TestCase("https://www.yandex.ru", "YaN", "https://www."),
+
+ // Prefix suffix does not match.
+ TestCase("https://www.yandex.ru", "index", ""),
+ };
+
+ for (const TestCase& test_case : test_cases) {
+ const URLPrefix* prefix =
+ URLPrefix::BestURLPrefix(test_case.text, test_case.prefix_suffix);
+ if (test_case.expected_prefix.empty()) {
+ EXPECT_FALSE(prefix);
+ } else {
+ ASSERT_TRUE(prefix);
+ EXPECT_EQ(test_case.expected_prefix, prefix->prefix);
+ }
+ }
+}
« no previous file with comments | « components/omnibox/browser/url_prefix.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698