Optimize URLPrefix::BestURLPrefix

components/omnibox/browser/url_prefix.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/url_prefix.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 
 namespace {
 
-// Like URLPrefix::BestURLPrefix() except also handles the prefix of
+// This is an implementation method for BestURLPrefix function.
+// It accepts input text and prefix suffix already converted to lower case.
+const URLPrefix* BestURLPrefixInternal(
+    const base::string16& lower_text,
+    const base::string16& lower_prefix_suffix) {
+  const URLPrefixes& list = URLPrefix::GetURLPrefixes();
+  for (const URLPrefix& prefix : list)

[Peter Kasting, 2016/04/23 00:31:01]

Nit: {}

[Alexander Yashkin, 2016/04/23 08:40:20]

Done.

+    if (base::StartsWith(lower_text, prefix.prefix + lower_prefix_suffix,
+                         base::CompareCase::SENSITIVE))
+      return &prefix;
+  return nullptr;
+}
+
+// Like URLPrefix::BestURLPrefixInternal() except also handles the prefix of

[Peter Kasting, 2016/04/23 00:31:01]

Nit: URLPrefix:: qualifier is incorrect

[Alexander Yashkin, 2016/04/23 08:40:19]

Done.

 // "www.".
 const URLPrefix* BestURLPrefixWithWWWCase(
-    const base::string16& text,
-    const base::string16& prefix_suffix) {
+    const base::string16& lower_text,
+    const base::string16& lower_prefix_suffix) {
   CR_DEFINE_STATIC_LOCAL(URLPrefix, www_prefix,
                          (base::ASCIIToUTF16("www."), 1));
-  const URLPrefix* best_prefix = URLPrefix::BestURLPrefix(text, prefix_suffix);
-  if ((best_prefix == NULL) ||
-      (best_prefix->num_components < www_prefix.num_components)) {
-    if (URLPrefix::PrefixMatch(www_prefix, text, prefix_suffix))
+  const URLPrefix* best_prefix =
+      BestURLPrefixInternal(lower_text, lower_prefix_suffix);
+  if ((best_prefix == nullptr) || (best_prefix->num_components == 0)) {

[Peter Kasting, 2016/04/23 00:31:01]

Nit: I think "(best_prefix->num_components < www_prefix.num_components)" was
clearer about the reason for the check than "== 0".

[Alexander Yashkin, 2016/04/23 08:40:19]

Done.

+    if (base::StartsWith(lower_text, www_prefix.prefix + lower_prefix_suffix,
+                         base::CompareCase::SENSITIVE))

[Peter Kasting, 2016/04/23 00:31:01]

Nit: Combine nested ifs

[Alexander Yashkin, 2016/04/23 08:40:19]

Done.

       best_prefix = &www_prefix;
   }
   return best_prefix;
 }
 
 }  // namespace
 
-URLPrefix::URLPrefix(const base::string16& prefix, size_t num_components)
-    : prefix(prefix),
+URLPrefix::URLPrefix(const base::string16& lower_prefix, size_t num_components)
+    : prefix(lower_prefix),
       num_components(num_components) {
+  // Input prefix must be in lower case.

[Peter Kasting, 2016/04/23 00:31:01]

Nit: lowercase

[Alexander Yashkin, 2016/04/23 08:40:19]

Done.

+  DCHECK_EQ(lower_prefix, base::i18n::ToLower(lower_prefix));
 }
 
 // static
 const URLPrefixes& URLPrefix::GetURLPrefixes() {
   CR_DEFINE_STATIC_LOCAL(URLPrefixes, prefixes, ());
   if (prefixes.empty()) {
     prefixes.push_back(URLPrefix(base::ASCIIToUTF16("https://www."), 2));
     prefixes.push_back(URLPrefix(base::ASCIIToUTF16("http://www."), 2));
     prefixes.push_back(URLPrefix(base::ASCIIToUTF16("ftp://www."), 2));
     prefixes.push_back(URLPrefix(base::ASCIIToUTF16("https://"), 1));
     prefixes.push_back(URLPrefix(base::ASCIIToUTF16("http://"), 1));
     prefixes.push_back(URLPrefix(base::ASCIIToUTF16("ftp://"), 1));
     prefixes.push_back(URLPrefix(base::string16(), 0));
   }
   return prefixes;
 }
 
 // static
-bool URLPrefix::IsURLPrefix(const base::string16& prefix) {
-  const URLPrefixes& list = GetURLPrefixes();
-  for (URLPrefixes::const_iterator i = list.begin(); i != list.end(); ++i)
-    if (i->prefix == prefix)
-      return true;
-  return false;
-}
-
-// static
 const URLPrefix* URLPrefix::BestURLPrefix(const base::string16& text,
                                           const base::string16& prefix_suffix) {
-  const URLPrefixes& list = GetURLPrefixes();
-  for (URLPrefixes::const_iterator i = list.begin(); i != list.end(); ++i)
-    if (PrefixMatch(*i, text, prefix_suffix))
-      return &(*i);
-  return NULL;
+  return BestURLPrefixInternal(base::i18n::ToLower(text),
+                               base::i18n::ToLower(prefix_suffix));
 }
 
 // static
-bool URLPrefix::PrefixMatch(const URLPrefix& prefix,
-                            const base::string16& text,
-                            const base::string16& prefix_suffix) {
-  return base::StartsWith(
-      base::i18n::ToLower(text),
-      base::i18n::ToLower(prefix.prefix + prefix_suffix),
-      base::CompareCase::SENSITIVE);
-}
-
-// static
 size_t URLPrefix::GetInlineAutocompleteOffset(
     const base::string16& input,
     const base::string16& fixed_up_input,
     const bool allow_www_prefix_without_scheme,
     const base::string16& text) {
-  const URLPrefix* best_prefix = allow_www_prefix_without_scheme ?
-      BestURLPrefixWithWWWCase(text, input) : BestURLPrefix(text, input);
+  const base::string16 lower_text(base::i18n::ToLower(text));
+  const base::string16 lower_input(base::i18n::ToLower(input));
+  const URLPrefix* best_prefix =
+      allow_www_prefix_without_scheme
+          ? BestURLPrefixWithWWWCase(lower_text, lower_input)
+          : BestURLPrefixInternal(lower_text, lower_input);
   const base::string16* matching_string = &input;
   // If we failed to find a best_prefix initially, try again using a fixed-up
   // version of the user input.  This is especially useful to get about: URLs
   // to inline against chrome:// shortcuts.  (about: URLs are fixed up to the
   // chrome:// scheme.)
   if (!best_prefix && !fixed_up_input.empty() && (fixed_up_input != input)) {
-    best_prefix = allow_www_prefix_without_scheme ?
-        BestURLPrefixWithWWWCase(text, fixed_up_input) :
-        BestURLPrefix(text, fixed_up_input);
+    const base::string16 lower_fixed_up_input(
+        base::i18n::ToLower(fixed_up_input));
+    best_prefix =
+        allow_www_prefix_without_scheme
+            ? BestURLPrefixWithWWWCase(lower_text, lower_fixed_up_input)
+            : BestURLPrefixInternal(lower_text, lower_fixed_up_input);
     matching_string = &fixed_up_input;
   }
   return (best_prefix != NULL) ?
       (best_prefix->prefix.length() + matching_string->length()) :
       base::string16::npos;
 }