Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1897383004:
Added XSLT translate test (Closed)
DescriptionAdded XSLT translate test
This test is for detecting an error caused by a compiler
bug on Windows (which is now worked around by
crrev.com/1878963005).
I've verified that the test is failing without the
workaround by temporarily undoing it (by switching the optimization from speed to size).
BUG=599427
Committed: https://crrev.com/e2c0c25fa28142b5064e0fc9d9ae8dd749352bbe
Cr-Commit-Position: refs/heads/master@{#388594}
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
brucedawson@chromium.org changed reviewers: + brucedawson@chromium.org
Maybe update title and/or description to mention that this is for detecting an error caused by a compiler bug (now worked around). To sanity check this maybe try temporarily undoing crrev.com/1878963005 to make sure that the bug is detected, although I'm not sure if it reproes in normal release builds or if it requires an official build. Thanks for adding this test! lgtm
Description was changed from ========== Added XSLT translate test BUG=599427 ========== to ========== Added XSLT translate test This test is for detecting an error caused by a compiler bug on Windows (which is now worked around). I've verified that the test is failing without the workaround by temporarily undoing effect of crrev.com/1878963005 by switching the optimization from "t" (speed) to "s" (size). BUG=599427 ==========
Description was changed from ========== Added XSLT translate test This test is for detecting an error caused by a compiler bug on Windows (which is now worked around). I've verified that the test is failing without the workaround by temporarily undoing effect of crrev.com/1878963005 by switching the optimization from "t" (speed) to "s" (size). BUG=599427 ========== to ========== Added XSLT translate test This test is for detecting an error caused by a compiler bug on Windows (which is now worked around by crrev.com/1878963005). I've verified that the test is failing without the workaround by temporarily undoing it (by switching the optimization from speed to size). BUG=599427 ==========
stanisc@chromium.org changed reviewers: + scottmg@chromium.org
scottmg@, please take a look.
On 2016/04/20 18:16:40, stanisc wrote: > scottmg@, please take a look. Microsoft just commented on the original bug. Based on their comments and some PGO thoughts I may update the bug workaround to make it more stable, but not until after this test lands - I want automated testing of my hacks.
Thanks, lgtm (but I'm not owner in Blink)
On 2016/04/20 21:05:13, scottmg wrote: > Thanks, lgtm (but I'm not owner in Blink) It's clear who the appropriate owner would be, oddly enough. "git cl presubmit" says the change is okay, LayoutTests\OWNERS only lists owners for SmokeTests and WebKit\OWNERS is similarly sparse. Odd...
Anyone is fine; normally whoever reviewed the code that goes with it would review the LayoutTest. On Wed, Apr 20, 2016 at 2:16 PM, <brucedawson@chromium.org> wrote: > On 2016/04/20 21:05:13, scottmg wrote: > > Thanks, lgtm (but I'm not owner in Blink) > > It's clear who the appropriate owner would be, oddly enough. "git cl > presubmit" > says the change is okay, LayoutTests\OWNERS only lists owners for > SmokeTests and > WebKit\OWNERS is similarly sparse. Odd... > > https://codereview.chromium.org/1897383004/ > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to chromium-reviews+unsubscribe@chromium.org. > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Anyone is fine; normally whoever reviewed the code that goes with it would review the LayoutTest. On Wed, Apr 20, 2016 at 2:16 PM, <brucedawson@chromium.org> wrote: > On 2016/04/20 21:05:13, scottmg wrote: > > Thanks, lgtm (but I'm not owner in Blink) > > It's clear who the appropriate owner would be, oddly enough. "git cl > presubmit" > says the change is okay, LayoutTests\OWNERS only lists owners for > SmokeTests and > WebKit\OWNERS is similarly sparse. Odd... > > https://codereview.chromium.org/1897383004/ > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to chromium-reviews+unsubscribe@chromium.org. > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by stanisc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897383004/1
Message was sent while issue was closed.
Description was changed from ========== Added XSLT translate test This test is for detecting an error caused by a compiler bug on Windows (which is now worked around by crrev.com/1878963005). I've verified that the test is failing without the workaround by temporarily undoing it (by switching the optimization from speed to size). BUG=599427 ========== to ========== Added XSLT translate test This test is for detecting an error caused by a compiler bug on Windows (which is now worked around by crrev.com/1878963005). I've verified that the test is failing without the workaround by temporarily undoing it (by switching the optimization from speed to size). BUG=599427 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Added XSLT translate test This test is for detecting an error caused by a compiler bug on Windows (which is now worked around by crrev.com/1878963005). I've verified that the test is failing without the workaround by temporarily undoing it (by switching the optimization from speed to size). BUG=599427 ========== to ========== Added XSLT translate test This test is for detecting an error caused by a compiler bug on Windows (which is now worked around by crrev.com/1878963005). I've verified that the test is failing without the workaround by temporarily undoing it (by switching the optimization from speed to size). BUG=599427 Committed: https://crrev.com/e2c0c25fa28142b5064e0fc9d9ae8dd749352bbe Cr-Commit-Position: refs/heads/master@{#388594} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e2c0c25fa28142b5064e0fc9d9ae8dd749352bbe Cr-Commit-Position: refs/heads/master@{#388594} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
