Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1897363004: Reland of Implement support for vp9 in ISO-BMFF (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, DaleCurtis, xhwang, tinskip1, fgalligan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Implement support for vp9 in ISO-BMFF (patchset #1 id:1 of https://codereview.chromium.org/1899423002/ ) Reason for revert: My suspicion was wrong. The reverted CL was not the culprit. Original issue's description: > Revert of Implement support for vp9 in ISO-BMFF (patchset #15 id:280001 of https://codereview.chromium.org/1624703002/ ) > > Reason for revert: > Suspect for perf regression: increased the number of static initializers (in stream_parser_factory.cc). > > https://build.chromium.org/p/chromium/builders/Mac/builds/14593 > https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/18412 > > See crbug.com/605017 for more details. > > Original issue's description: > > Implement support for vp9 in ISO-BMFF > > > > The feature is implemented under flag ENABLE_MP4_VP9_DEMUXING, off for now. > > > > BUG=580623 > > TBR=ddorwin@chromium.org,sandersd@chromium.org,wolenetz@chromium.org,xhwang@chromium.org,kqyang@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=580623, 605017 TBR=ddorwin@chromium.org,sandersd@chromium.org,wolenetz@chromium.org,xhwang@chromium.org,kqyang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=580623, 605017 Committed: https://crrev.com/12b50592aaa21512a756cb4d520e56ffa91bb34f Cr-Commit-Position: refs/heads/master@{#388442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -71 lines) Patch
M chrome/browser/media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 12 chunks +81 lines, -0 lines 0 comments Download
M media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/eme_constants.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/key_systems.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M media/base/mime_util_internal.h View 1 chunk +6 lines, -4 lines 0 comments Download
M media/base/mime_util_internal.cc View 7 chunks +128 lines, -6 lines 0 comments Download
M media/base/mime_util_unittest.cc View 1 chunk +12 lines, -1 line 0 comments Download
M media/filters/stream_parser_factory.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M media/formats/mp4/box_definitions.cc View 2 chunks +56 lines, -48 lines 0 comments Download
M media/formats/mp4/fourccs.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M media/test/data/README View 1 chunk +4 lines, -0 lines 0 comments Download
A media/test/data/bear-320x240-v_frag-vp9.mp4 View Binary file 0 comments Download
A media/test/data/bear-320x240-v_frag-vp9-cenc.mp4 View Binary file 0 comments Download
M media/test/pipeline_integration_test.cc View 4 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
msramek
Created Reland of Implement support for vp9 in ISO-BMFF
4 years, 8 months ago (2016-04-20 08:14:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897363004/1
4 years, 8 months ago (2016-04-20 08:15:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 08:15:43 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:21:29 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12b50592aaa21512a756cb4d520e56ffa91bb34f
Cr-Commit-Position: refs/heads/master@{#388442}

Powered by Google App Engine
This is Rietveld 408576698