Componentize OriginsSeenService & provide iOS factory.

Componentize OriginsSeenService & provide iOS factory.

Chrome on iOS calls navigation_metrics::RecordMainFrameNavigation,
so componentize OriginsSeenService and provide an iOS factory to
share code.

BUG=604659
Committed: https://crrev.com/54193e78c3f3143818a393f5d677a342422c6b5b
Cr-Commit-Position: refs/heads/master@{#392572}

[sdefresne, 2016-04-20 07:09:02]

sdefresne@chromium.org changed reviewers:
+ cbentzel@chromium.org, noyau@chromium.org, sky@chromium.org

[sdefresne, 2016-04-20 07:09:02]

This is a followup to https://codereview.chromium.org/1844753002. As I
commented, navigation_metrics::RecordMainFrameNavigation is called from iOS
downstream code. To share the code between iOS and the other platforms, I have
componentised the class introduced in said CL and chose to move it to
navigation_metrics component as it is used in conjunction with it.

sky: please review as OWNERS of chrome/browser/tab_contents/ (direct OWNERS avi
is OOO till the 2nd of May)

cbentzel: can you review as OWNERS of components/navigation_metrics

noyau: can you review //ios?

[noyau (Ping after 24h), 2016-04-20 09:25:06]

ios lgtm.

[sdefresne, 2016-04-20 09:27:33]

On 2016/04/20 at 09:25:06, noyau wrote:
> ios lgtm.

To summarize offline discussion, the class IOSChromeOriginsSeenServiceFactory is
not used in that CL as the call will have to be done in iOS downstream
repository for the time being.

[sky, 2016-04-20 19:28:03]

LGTM

https://codereview.chromium.org/1897343003/diff/20001/chrome/browser/tab_cont...
File chrome/browser/tab_contents/origins_seen_service_factory.h (right):

https://codereview.chromium.org/1897343003/diff/20001/chrome/browser/tab_cont...
chrome/browser/tab_contents/origins_seen_service_factory.h:10: #include
"components/navigation_metrics/origins_seen_service.h"
Is this include necessary here Doesn't the forward declaration cover it?

[sdefresne, 2016-04-21 16:00:51]

cbentzel: ping

[cbentzel, 2016-04-29 13:20:10]

On 2016/04/21 16:00:51, sdefresne wrote:
> cbentzel: ping

components/navigation_metrics LGTM

Very sorry for the delay

There's still one little unresolve nit mentioned by sky.

[sdefresne, 2016-05-10 09:07:16]

Thank you all for the review.

https://codereview.chromium.org/1897343003/diff/20001/chrome/browser/tab_cont...
File chrome/browser/tab_contents/origins_seen_service_factory.h (right):

https://codereview.chromium.org/1897343003/diff/20001/chrome/browser/tab_cont...
chrome/browser/tab_contents/origins_seen_service_factory.h:10: #include
"components/navigation_metrics/origins_seen_service.h"
On 2016/04/20 19:28:03, sky wrote:
> Is this include necessary here Doesn't the forward declaration cover it?

No, it is not required, removed.

[sdefresne, 2016-05-10 09:07:57]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-05-10 09:07:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbentzel@chromium.org, noyau@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1897343003/#ps40001
(title: "Rebase and address nit")

[commit-bot: I haz the power, 2016-05-10 09:08:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897343003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897343003/40001

[commit-bot: I haz the power, 2016-05-10 09:16:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-10 09:19:18]

Description was changed from

==========
Componentize OriginsSeenService & provide iOS factory.

Chrome on iOS calls navigation_metrics::RecordMainFrameNavigation,
so componentize OriginsSeenService and provide an iOS factory to
share code.

BUG=604659
==========

to

==========
Componentize OriginsSeenService & provide iOS factory.

Chrome on iOS calls navigation_metrics::RecordMainFrameNavigation,
so componentize OriginsSeenService and provide an iOS factory to
share code.

BUG=604659

Committed: https://crrev.com/54193e78c3f3143818a393f5d677a342422c6b5b
Cr-Commit-Position: refs/heads/master@{#392572}
==========

[commit-bot: I haz the power, 2016-05-10 09:19:19]

Patchset 3 (id:??) landed as
https://crrev.com/54193e78c3f3143818a393f5d677a342422c6b5b
Cr-Commit-Position: refs/heads/master@{#392572}