third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp - Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h ('k') | third_party/WebKit/Source/platform/graphics/filters/ImageFilterBuilderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

index c92c651cd411e94b93763d016f382c73ebfa47a4..c47d9d99b41ab90f5cde2de788cc2c782d9d53c0 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

@@ -189,14 +189,14 @@ FloatRect FilterEffect::determineFilterPrimitiveSubregion(DetermineSubregionFlag

return subregion;

}

-sk_sp<SkImageFilter> FilterEffect::createImageFilter(SkiaImageFilterBuilder&)

+sk_sp<SkImageFilter> FilterEffect::createImageFilter()

{

return nullptr;

}

-sk_sp<SkImageFilter> FilterEffect::createImageFilterWithoutValidation(SkiaImageFilterBuilder& builder)

+sk_sp<SkImageFilter> FilterEffect::createImageFilterWithoutValidation()

{

- return createImageFilter(builder);

+ return createImageFilter();

}

bool FilterEffect::inputsTaintOrigin() const

@@ -208,7 +208,7 @@ bool FilterEffect::inputsTaintOrigin() const

return false;

}

-sk_sp<SkImageFilter> FilterEffect::createTransparentBlack(SkiaImageFilterBuilder& builder) const

+sk_sp<SkImageFilter> FilterEffect::createTransparentBlack() const

{

SkImageFilter::CropRect rect = getCropRect();

sk_sp<SkColorFilter> colorFilter = SkColorFilter::MakeModeFilter(0, SkXfermode::kClear_Mode);