third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp - Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEMorphology.h ('k') | third_party/WebKit/Source/platform/graphics/filters/FEOffset.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

index 3e13fe8461522bcf5c8f1738c96b421c64577265..c63c6db33a4ddabe7565e0e284dc40147a77a43a 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp

@@ -93,9 +93,9 @@ FloatRect FEMorphology::mapRect(const FloatRect& rect, bool) const

return result;

}

-sk_sp<SkImageFilter> FEMorphology::createImageFilter(SkiaImageFilterBuilder& builder)

+sk_sp<SkImageFilter> FEMorphology::createImageFilter()

{

- sk_sp<SkImageFilter> input(builder.build(inputEffect(0), operatingColorSpace()));

+ sk_sp<SkImageFilter> input(SkiaImageFilterBuilder::build(inputEffect(0), operatingColorSpace()));

SkScalar radiusX = SkFloatToScalar(getFilter()->applyHorizontalScale(m_radiusX));

SkScalar radiusY = SkFloatToScalar(getFilter()->applyVerticalScale(m_radiusY));

SkImageFilter::CropRect rect = getCropRect();