third_party/WebKit/Source/platform/graphics/filters/FELighting.h - Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FELighting.h

Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FELighting.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FELighting.h b/third_party/WebKit/Source/platform/graphics/filters/FELighting.h

index 649116c2bd0fb6c1f73d6d520c8cc028d032f58b..4ce52481366da30a649c11dc8d3de84dfd13f93d 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FELighting.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/FELighting.h

@@ -44,7 +44,7 @@ protected:

SpecularLighting

};

- sk_sp<SkImageFilter> createImageFilter(SkiaImageFilterBuilder&) override;

+ sk_sp<SkImageFilter> createImageFilter() override;

FloatRect mapPaintRect(const FloatRect&, bool forward = true) const final;

bool affectsTransparentPixels() override { return true; }