third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp - Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h ('k') | third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

index fd9b8c6bbfe663d4b1db7871bd04e3f7c1fdfc60..0101f44b8bb1a7f72e5cafd57a6a4595d33285ef 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

@@ -136,12 +136,12 @@ bool FEConvolveMatrix::parametersValid() const

return true;

}

-sk_sp<SkImageFilter> FEConvolveMatrix::createImageFilter(SkiaImageFilterBuilder& builder)

+sk_sp<SkImageFilter> FEConvolveMatrix::createImageFilter()

{

if (!parametersValid())

- return createTransparentBlack(builder);

+ return createTransparentBlack();

- sk_sp<SkImageFilter> input(builder.build(inputEffect(0), operatingColorSpace()));

+ sk_sp<SkImageFilter> input(SkiaImageFilterBuilder::build(inputEffect(0), operatingColorSpace()));

SkISize kernelSize(SkISize::Make(m_kernelSize.width(), m_kernelSize.height()));

// parametersValid() above checks that the kernel area fits in int.

int numElements = safeCast<int>(m_kernelSize.area());