third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp - Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp

Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.h ('k') | third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp

index 1d8da7f33b96fdfc79cc0d505782dbe32d87bcc1..8554cc88dc0dcab549c0555610b8f3d65106d2aa 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp

@@ -160,9 +160,9 @@ bool FEColorMatrix::affectsTransparentPixels()

return m_type == FECOLORMATRIX_TYPE_MATRIX && m_values.size() >= kColorMatrixSize && m_values[19] > 0;

}

-sk_sp<SkImageFilter> FEColorMatrix::createImageFilter(SkiaImageFilterBuilder& builder)

+sk_sp<SkImageFilter> FEColorMatrix::createImageFilter()

{

- sk_sp<SkImageFilter> input(builder.build(inputEffect(0), operatingColorSpace()));

+ sk_sp<SkImageFilter> input(SkiaImageFilterBuilder::build(inputEffect(0), operatingColorSpace()));

sk_sp<SkColorFilter> filter = createColorFilter(m_type, m_values);

SkImageFilter::CropRect rect = getCropRect();

return SkColorFilterImageFilter::Make(std::move(filter), std::move(input), &rect);