third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp - Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

index db6ffe23d4374fdf97b4112ee7e16908f9785cd1..a3f0db113fa87f2c7f4a7dd676a44861273e9476 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

@@ -55,10 +55,10 @@ bool FEBlend::setBlendMode(WebBlendMode mode)

return true;

}

-sk_sp<SkImageFilter> FEBlend::createImageFilter(SkiaImageFilterBuilder& builder)

+sk_sp<SkImageFilter> FEBlend::createImageFilter()

{

- sk_sp<SkImageFilter> foreground(builder.build(inputEffect(0), operatingColorSpace()));

- sk_sp<SkImageFilter> background(builder.build(inputEffect(1), operatingColorSpace()));

+ sk_sp<SkImageFilter> foreground(SkiaImageFilterBuilder::build(inputEffect(0), operatingColorSpace()));

+ sk_sp<SkImageFilter> background(SkiaImageFilterBuilder::build(inputEffect(1), operatingColorSpace()));

sk_sp<SkXfermode> mode(SkXfermode::Make(WebCoreCompositeToSkiaComposite(CompositeSourceOver, m_mode)));

SkImageFilter::CropRect cropRect = getCropRect();

return SkXfermodeImageFilter::Make(std::move(mode), std::move(background), std::move(foreground), &cropRect);