third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp - Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 1897333002: Refactor SkiaImageFilterBuilder into a namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp ('k') | third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

index d7956f3053d4434959c27fc38992e19f21e3bb0e..c76cff5f2062e30bd3d4386f974e194517d64586 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

@@ -317,12 +317,11 @@ SkImageFilter* CanvasRenderingContext2DState::getFilter(Element* styleResolution

const double effectiveZoom = 1.0; // Deliberately ignore zoom on the canvas element

filterEffectBuilder->build(styleResolutionHost, filterStyle->filter(), effectiveZoom, &floatCanvasSize, &fillPaintForFilter, &strokePaintForFilter);

- SkiaImageFilterBuilder imageFilterBuilder;

FilterEffect* lastEffect = filterEffectBuilder->lastEffect();

if (lastEffect) {

lastEffect->determineFilterPrimitiveSubregion();

}

- m_resolvedFilter = imageFilterBuilder.build(lastEffect, ColorSpaceDeviceRGB);

+ m_resolvedFilter = SkiaImageFilterBuilder::build(lastEffect, ColorSpaceDeviceRGB);

if (m_resolvedFilter) {

updateFilterReferences(toHTMLCanvasElement(styleResolutionHost), context, filterStyle->filter());

if (lastEffect->originTainted())