Issue 1897323002: Added definition of ALLOW_WASM to CMakeLists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1897323002: Added definition of ALLOW_WASM to CMakeLists. (Closed)

Created:
4 years, 8 months ago by Sean Klein

Modified:
4 years, 8 months ago

Reviewers:
Eric Holk

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Added definition of ALLOW_WASM to CMakeLists. This change is required to run "toolchain_build_pnacl.py --cmake", since without it, ALLOW_WASM will be undefined and throw a compilation error. BUG=None R=eholk@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3d3507ce020cf43eb586c8e9d88e15b574aa4073

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	CMakeLists.txt	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Sean Klein

4 years, 8 months ago (2016-04-19 17:53:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3d3507ce020cf43eb586c8e9d88e15b574aa4073 (presubmit successful).