Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

Issue 1897263002: Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-1
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 15 matching lines...) Expand all
26 26
27 LayoutSVGHiddenContainer::LayoutSVGHiddenContainer(SVGElement* element) 27 LayoutSVGHiddenContainer::LayoutSVGHiddenContainer(SVGElement* element)
28 : LayoutSVGContainer(element) 28 : LayoutSVGContainer(element)
29 { 29 {
30 } 30 }
31 31
32 void LayoutSVGHiddenContainer::layout() 32 void LayoutSVGHiddenContainer::layout()
33 { 33 {
34 ASSERT(needsLayout()); 34 ASSERT(needsLayout());
35 LayoutAnalyzer::Scope analyzer(*this); 35 LayoutAnalyzer::Scope analyzer(*this);
36 SVGLayoutSupport::layoutChildren(this, selfNeedsLayout()); 36 // TODO(fs): In what cases do we need this?
37 bool transformChanged = SVGLayoutSupport::transformToRootChanged(this);
38 SVGLayoutSupport::layoutChildren(this, selfNeedsLayout(), transformChanged);
pdr. 2016/04/19 18:53:44 Can you remove this and see what tests fail, and f
fs 2016/04/19 19:39:56 Yepp, I intend to.
37 updateCachedBoundaries(); 39 updateCachedBoundaries();
38 clearNeedsLayout(); 40 clearNeedsLayout();
39 } 41 }
40 42
41 void LayoutSVGHiddenContainer::paint(const PaintInfo&, const LayoutPoint&) const 43 void LayoutSVGHiddenContainer::paint(const PaintInfo&, const LayoutPoint&) const
42 { 44 {
43 // This subtree does not paint. 45 // This subtree does not paint.
44 } 46 }
45 47
46 void LayoutSVGHiddenContainer::absoluteQuads(Vector<FloatQuad>&) const 48 void LayoutSVGHiddenContainer::absoluteQuads(Vector<FloatQuad>&) const
47 { 49 {
48 // This subtree does not take up space or paint 50 // This subtree does not take up space or paint
49 } 51 }
50 52
51 bool LayoutSVGHiddenContainer::nodeAtFloatPoint(HitTestResult&, const FloatPoint &, HitTestAction) 53 bool LayoutSVGHiddenContainer::nodeAtFloatPoint(HitTestResult&, const FloatPoint &, HitTestAction)
52 { 54 {
53 return false; 55 return false;
54 } 56 }
55 57
56 } // namespace blink 58 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698