Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-update-exception-order.html

Issue 1897253003: IndexedDB: Align exception priorities with Firefox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback: more cases, split files, better messages Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-update-exception-order.html
diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-update-exception-order.html b/third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-update-exception-order.html
new file mode 100644
index 0000000000000000000000000000000000000000..e0cdf8077a86bb05bf8e12dc64a543fe9a6e4d5b
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-update-exception-order.html
@@ -0,0 +1,99 @@
+<!DOCTYPE html>
+<title>IndexedDB: IDBCursor update() Exception Ordering</title>
+<link rel="help" href="https://w3c.github.io/IndexedDB/#dom-idbcursor-update">
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script src="resources/testharness-helpers.js"></script>
+
+<script>
+
+indexeddb_test(
+ function(t, db) {
+ var s = db.createObjectStore('s');
+ s.put('value', 'key');
+ },
+ function(t, db) {
+ var s = db.transaction('s', 'readonly').objectStore('s');
+ var r = s.openCursor();
+ r.onsuccess = t.step_func(function() {
+ r.onsuccess = null;
+ var cursor = r.result;
+ setTimeout(t.step_func(function() {
+ assert_throws('TransactionInactiveError', function() {
+ cursor.update('value2');
+ }, '"Transaction inactive" check (TransactionInactiveError) ' +
+ 'should precede "read only" check (ReadOnlyError)');
+ t.done();
+ }), 0);
+ });
+ },
+ 'IDBCursor.update exception order: TransactionInactiveError vs. ReadOnlyError'
+);
+
+indexeddb_test(
+ function(t, db) {
+ var s = db.createObjectStore('s');
+ s.put('value', 'key');
+ },
+ function(t, db) {
+ var s = db.transaction('s', 'readonly').objectStore('s');
+ var r = s.openCursor();
+ r.onsuccess = t.step_func(function() {
+ r.onsuccess = null;
+ var cursor = r.result;
+ cursor.continue();
+ assert_throws('ReadOnlyError', function() {
+ cursor.update('value2');
+ }, '"Read only" check (ReadOnlyError) should precede '+
+ '"got value flag" check (InvalidStateError)');
+ t.done();
+ });
+ },
+ 'IDBCursor.update exception order: ReadOnlyError vs. InvalidStateError #1'
+);
+
+indexeddb_test(
+ function(t, db) {
+ var s = db.createObjectStore('s');
+ s.put('value', 'key');
+ },
+ function(t, db) {
+ var s = db.transaction('s', 'readonly').objectStore('s');
+ var r = s.openKeyCursor();
+ r.onsuccess = t.step_func(function() {
+ r.onsuccess = null;
+ var cursor = r.result;
+ cursor.continue();
+ assert_throws('ReadOnlyError', function() {
+ cursor.update('value2');
+ }, '"Read only" check (ReadOnlyError) should precede '+
+ '"key only flag" check (InvalidStateError)');
+ t.done();
+ });
+ },
+ 'IDBCursor.update exception order: ReadOnlyError vs. InvalidStateError #2'
+);
+
+indexeddb_test(
+ function(t, db) {
+ var s = db.createObjectStore('s', {keyPath: 'id'});
+ s.put({id: 123, data: 'value'});
+ },
+ function(t, db) {
+ var s = db.transaction('s', 'readwrite').objectStore('s');
+ var r = s.openCursor();
+ r.onsuccess = t.step_func(function() {
+ r.onsuccess = null;
+ var cursor = r.result;
+ cursor.continue();
+ assert_throws('InvalidStateError', function() {
+ cursor.update({id: 123, data: 'value2'});
+ }, '"Got value flag" check (InvalidStateError) should precede ' +
+ '"modified key" check (DataError)');
+ t.done();
+ });
+ },
+ 'IDBCursor.update exception order: InvalidStateError vs. DataError'
+);
+
+</script>

Powered by Google App Engine
This is Rietveld 408576698